Repository navigation
Debug build doesn't work on Windows #25593
Description
Activity
cc @nodejs/platform-windows
Confirmed.
I'm not sure it's a Compiler bug, it might be Undefined Behavior. I think I was able to fix this by reordering the singleton declarations (*OptionsParser::instance) innode_options.ccby their order of dependency. e.g.Line 121 in 17c6b1d
They are already in the dependency order, aren't they?
They are already in the dependency order, aren't they?
I think there is something more subtle that is related to
static init order. But I didn't fully grok this.I found my patch: #25596
The static init order thing is irrelevant, they are all in the same translation unit here.
That's a usage, not a definition.
Are we sure those two lines are not part of some other static construction?
Or alternatively thatisn't optimized away?Line 121 in 17c6b1d
Are we sure those two lines are not part of some other static construction?
Based on grepping the source code for
cli_options, I would say that this is not the case, yes. The way in which @seishun narrowed down the issue might tell us more?Reacted by Refael AckermannNarrowing it down was easy, I just pressed F5 and saw that the
DebugOptionsParserinstance is full of zeroes inside theEnvironmentOptionsParserconstructor, and then confirmed it by setting a breakpoint in theDebugOptionsParserand seeing that it's never hit.I'm now trying to come up with a minimal test case.
From
dumpbin /all node_options.objoutput:Symbol Symbol Offset Type Applied To Index Name -------- ---------------- ----------------- -------- ------ 00000000 ADDR64 00000000 00000000 5219 ??__E?instance@EnvironmentOptionsParser@options_parser@node@@2V123@B@@YAXXZ (void __cdecl `dynamic initializer for 'public: static class node::options_parser::EnvironmentOptionsParser const node::options_parser::EnvironmentOptionsParser::instance''(void)) 00000008 ADDR64 00000000 00000000 521C ??__E?instance@PerIsolateOptionsParser@options_parser@node@@2V123@B@@YAXXZ (void __cdecl `dynamic initializer for 'public: static class node::options_parser::PerIsolateOptionsParser const node::options_parser::PerIsolateOptionsParser::instance''(void)) 00000010 ADDR64 00000000 00000000 521F ??__E?instance@PerProcessOptionsParser@options_parser@node@@2V123@B@@YAXXZ (void __cdecl `dynamic initializer for 'public: static class node::options_parser::PerProcessOptionsParser const node::options_parser::PerProcessOptionsParser::instance''(void)) 00000018 ADDR64 00000000 00000000 5208 ??__Ecli_options_mutex@per_process@node@@YAXXZ (void __cdecl node::per_process::`dynamic initializer for 'cli_options_mutex''(void)) 00000020 ADDR64 00000000 00000000 520F ??__Ecli_options@per_process@node@@YAXXZ (void __cdecl node::per_process::`dynamic initializer for 'cli_options''(void)) 00000028 ADDR64 00000000 00000000 5216 ??__E?instance@DebugOptionsParser@options_parser@node@@2V123@B@@YAXXZ (void __cdecl `dynamic initializer for 'public: static class node::options_parser::DebugOptionsParser const node::options_parser::DebugOptionsParser::instance''(void))I wonder if
cli_options_mutexorcli_optionsis throwing it off somehow?Correct, this is from the
.CRT$XCUsection, which defines the dynamic initialization order (CRT Initialization).Reacted by Anna HenningsenI'm now trying to come up with a minimal test case.
Too difficult, the bug disappears when removing random lines. Is there someone in the Visual Studio team we could ping here?
6 remaining items
- added 2 commits that reference this issue
on Mar 4, 2019
A debug build built using
vcbuild debugand the latest VS2017 exits immediately. It seems to be a compiler bug: theEnvironmentOptionsParserinstance is initialized before theDebugOptionsParserinstance, causing a segfault. I would like someone to confirm the issue before I continue looking into it.