Investigate flaky test test-child-process-spawnsync #2470

Activity

1. joaocgreis

   added

   buildIssues and PRs related to Node.js builds or CI infrastructure.Issues and PRs related to Node.js builds or CI infrastructure.

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   on Aug 20, 2015
2. Trott commented on Aug 25, 2015

   

   Trott

   on Aug 25, 2015

   Member

   More actions

   If I'm understanding the test correctly, the part of the test that is flaky is actually invalid. It checks to see if the function passed to setTimeout() executes in the same second as call to spawnSync() finishes. This will not always necessarily be the case, and the test will only get flakier if more things are added to it. (There are two other test cases below the flaky one.)

   There's already an assertion to confirm that the spawnSync() ends before setTimeout() runs, so I'll submit a PR to remove the check altogether rather than do something like convert the timestamps to nanoseconds since start and make sure the one set by setTimeout() is greater than the one set by spawnSync().
3. Trott commented on Aug 25, 2015

   

   Trott

   on Aug 25, 2015

   Member

   More actions

   Fixed in 7e63eb7 / #2535
4. Trott

   closed this as completedon Aug 25, 2015
5. Trott

   added a commit that references this issue on Aug 26, 2015

   test: make spawnSync() test robust

   ...

   856baf4