Repository navigation
Doc: Agent ctor options are not fully documented, such as lookup #24098
Description
Activity
Agreed, if the options are passed to net.connect (EDIT: sorry,
socket.connect()), the docs should say so. Can you PR a fix?@sam-github I will take a look at doc style guide and see what I can do.
@Trott I can take a spin at this if thats okay. I think we just need to look at the
socket.connect()options docs/code and add that into our Agent docs. Does that seem about right?- added a commit that references this issue
on Dec 8, 2018 - added a commit that references this issue
on Dec 17, 2018 - added a commit that references this issue
on Jan 14, 2019 - added a commit that references this issue
on Feb 12, 2019 - added a commit that references this issue
on Feb 20, 2019 - added a commit that references this issue
on Feb 28, 2019 This appears to have been fixed but never closed.
ref:
lookupoption fortls.connect()#12839issue:
socket.connect.new Agent([options]).agent.createConnection(options[, callback])does mention this but few users realize this allows them to make custom dns lookup via passing a custom Agent instance.