Repository navigation
intl: VS2015: workaround ICU VS2015 failure? #2279
Description
ICU (which provides Intl) failed under VS2015 in the same way and for the same reason as openssl in #478. Should we try to workaround?
I already committed a fix to IcuBug:11689, scheduled for release in a couple of months with ICU 56. If we hit this issue earlier, it looks like we could just pull a copy of ufile.c from ICU trunk on top of the downloaded ICU.
Just filing this for reference.
Activity
rvagg commentedon Jul 31, 2015
argh, 2015 is live now, it'd be a shame to have this as the only blocker.
is it possible to say something like "to build with VS2015 you must disable icu completely" or is it broken no matter how we look at it?
srl295 commentedon Jul 31, 2015
This is true at the moment. Sorry, I missed the scope of this issue before.
orangemocha commentedon Jul 31, 2015
Working on a repro. Is the icu lib itself that fails to build or does it fail at link time? We could change the download process to overwrite ufile.c from with a version from trunk (but at that point it would be better to commit it in our repo somewhere), or we could hack-define those missing functions somewhere else either in node or with an additional file for the icu library.
orangemocha commentedon Jul 31, 2015
Getting this error:
..which is at compile time, so my idea of defining the missing functions somewhere else won't help.
We should probably hack the build to use a different version of ufile.c then.
srl295 commentedon Jul 31, 2015
@orangemocha yes, that's the error. The particular function gets treated as "undefined assuming function returning int", and then somehow has a problem subscripting an int.
I/we/you can snag the
ufile.cfrom basically here and overwrite it in the situation ofvariables.icu_ver_major < 56and optionally&& MSVC 2015or justMSVC. I think thisufile.cwill work for ICU 54 and 55. And it's already checked in to the 56 stream.srl295 commentedon Jul 31, 2015
@orangemocha thanks for the discussion. I will open a PR here for a workaround.
srl295 commentedon Jul 31, 2015
oops, was looking for the Intl label!
build: work around VS2015 issue in ICU <56
joaocgreis commentedon Aug 14, 2015
Fixed by 4c06515.
build: work around VS2015 issue in ICU <56
build: work around VS2015 issue in ICU <56