Repository navigation
dns.promises test coverage is poor #22471
Description
Activity
@ChALkeR I will be happy to contribute in this issue.
Is there is an existing test file or should i create a new one (and if so - in which libary under "test"?)It's considerably less poor now that we run
internettests during coverage report generation. Right now, it's at 64 of 67 branches. Prior to that, it was 40 of 67.I'd welcome someone getting those last 3 branches covered, but I think this can nonetheless be closed at this time.
Ref: #20435 (comment)
Experimental
dns/promisesAPI is present in the currentmasterwithout proper test coverage.According to the coverage report, the following functions are not tested at all:
onlookuponlookupallonlookupservicecreateLookupServicePromiseWhile inspecting the experimental
fs.promises, there were also some implementation bugs found that could have been caught by code coverage, see e.g. #20407. Thedns.promisesis much smaller in lines of code, but it is still possible that it contains bugs that could be noticed by extending coverage.