Menacing thread safety comment in node_crypto.cc

@addaleax

Lines 2157 to 2160 in a40e062

    
           // XXX(bnoordhuis) X509_verify_cert_error_string() is not actually thread-safe 
        
           // in the presence of invalid error codes.  Probably academical but something 
        
           // to keep in mind if/when node ever grows multi-isolate capabilities. 
        
           const char* reason = X509_verify_cert_error_string(x509_verify_error);

Now that we have workers, the scenario described in the comment is here. Do we need to do anything about it? Or can we just change the comment to a simple note rather a XXX?

/cc @addaleax @bnoordhuis

This was actually fixed in openssl/openssl@c0a445a9f27. The comment is obsolete and can be removed.

crypto: remove outdated comment

Navigation Menu

Repository navigation

Menacing thread safety comment in node_crypto.cc #21488

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// XXX(bnoordhuis) X509_verify_cert_error_string() is not actually thread-safe
	// in the presence of invalid error codes. Probably academical but something
	// to keep in mind if/when node ever grows multi-isolate capabilities.
	const char* reason = X509_verify_cert_error_string(x509_verify_error);

Menacing thread safety comment in node_crypto.cc #21488

Description

Activity

bnoordhuis commented on Jun 23, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions