flaky: parallel/test-http2-* on Windows #20750

Activity

1. Trott

   added

   windowsIssues and PRs related to the Windows platform.Issues and PRs related to the Windows platform.

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.

   http2Issues and PRs related to the http2 subsystem.Issues and PRs related to the http2 subsystem.

   on May 15, 2018
2. apapirovski commented on May 15, 2018

   

   apapirovski

   on May 15, 2018

   Contributor

   More actions

   This happens as a result of the recent change to destroy the socket properly but it might be revealing an actual bug rather than just being a flaky test. That test does a pretty basic pipe operation, it shouldn't ever trigger an ECONNRESET.

   ping @nodejs/http2

   ❤️React with ❤️4Reacted by Rich Trott, سروش اربابی, tacoto12 and hardtolove2019
3. apapirovski commented on May 16, 2018

   

   apapirovski

   on May 16, 2018

   Contributor

   More actions

   This also just happened in parallel/test-http2-client-upload. Same root cause. It's definitely a bug.

   https://ci.nodejs.org/job/node-test-binary-windows/17277/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=3/tapResults/
4. Trott commented on May 16, 2018

   

   Trott

   on May 16, 2018

   MemberAuthor

   More actions

   For posterity (since the link provided by @apapirovski will eventually 404):

   not ok 231 parallel/test-http2-client-upload
     ---
     duration_ms: 0.220
     severity: fail
     exitcode: 1
     stack: |-
       (node:2492) ExperimentalWarning: The http2 module is an experimental API.
       events.js:167
             throw er; // Unhandled 'error' event
             ^
       
       Error: read ECONNRESET
           at TCP.onread (net.js:658:25)
       Emitted 'error' event at:
           at emitErrorNT (internal/streams/destroy.js:82:8)
           at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
           at process._tickCallback (internal/process/next_tick.js:63:19)
     ...

   Host: test-azure_msft-win2016-x64-2

   The fact that it's happening on both Azure and Rackspace, win2008 and win2016, seems to suggest (to me at least) a bug in Node.js or a dependency like libuv.
5. apapirovski commented on May 16, 2018

   

   apapirovski

   on May 16, 2018

   Contributor

   More actions

   Pretty sure it's because we use setImmediate to destroy rather than having some more certain method of confirming that everything has been sent and we're truly done. Hopefully someone else from the http2 team will have a look soon. I'm not on Windows and it's not a problem on macOS as far as I can tell.
6. mcollina commented on May 16, 2018

   

   mcollina

   on May 16, 2018

   SponsorMember

   More actions

   The bug on pipe happens on a mac too.
7. apapirovski commented on May 16, 2018

   

   apapirovski

   on May 16, 2018

   Contributor

   More actions

   @mcollina I can't seem to replicate on mine :( This is what I run it with: tools/test.py -j 96 --repeat 960 parallel/test-http2-pipe.
8. Trott commented on May 16, 2018

   

   Trott

   on May 16, 2018

   MemberAuthor

   More actions

   I also can't replicate on macOS nor do I see instances looking through macOS failures in Ci. It may very well be a bug on macOS too, but if so, we're definitely seeing it with much greater frequency on Windows in CI.
9. apapirovski commented on May 16, 2018

   

   apapirovski

   on May 16, 2018

   Last edited by apapirovski

   Contributor

   More actions

   I'm testing a possible fix in https://ci.nodejs.org/job/node-stress-single-test/1845/ and https://ci.nodejs.org/job/node-test-commit-windows-fanned/18023/
10. mcollina commented on May 16, 2018

    

    mcollina

    on May 16, 2018

    SponsorMember

    More actions

    === release test-http2-pipe ===
    Path: parallel/test-http2-pipe
    (node:37337) ExperimentalWarning: The http2 module is an experimental API.
    events.js:167
          throw er; // Unhandled 'error' event
          ^
    
    Error: read ECONNRESET
        at TCP.onread (net.js:658:25)
    Emitted 'error' event at:
        at emitErrorNT (internal/streams/destroy.js:82:8)
        at emitErrorAndCloseNT (internal/streams/destroy.js:50:3)
        at process._tickCallback (internal/process/next_tick.js:63:19)
    Command: out/Release/node /Users/matteo/Repositories/node/test/parallel/test-http2-pipe.js
    [01:05|% 100|+ 938|-  22]: Done
    

    On my system.
11. apapirovski

    added

    confirmed-bugIssues and PRs for confirmed bugs.Issues and PRs for confirmed bugs.

    and removed

    flaky-testIssues and PRs involving tests that fail intermittently in CI.Issues and PRs involving tests that fail intermittently in CI.

    on May 19, 2018
12. 118 remaining items

    Load more
13. codebytere

    added 2 commits that reference this issue on Mar 15, 2020

    test: fix flaky test-http2-stream-destroy-event-order

    ...

    73fb133

    test: fix flaky test-http2-stream-destroy-event-order

    ...

    502f42c
14. codebytere

    added a commit that references this issue on Mar 30, 2020

    test: fix flaky test-http2-stream-destroy-event-order

    ...

    02c2396
15. Trott

    closed this as completedin cd4b095on Mar 8, 2021
16. danielleadams

    added 2 commits that reference this issue on Mar 16, 2021

    test: clear FLAKY designation for test-http2-pipe

    ...

    381fb98

    test: clear flaky designation for test-stream-pipeline-http2

    ...

    d5ff50d
17. targos

    added 2 commits that reference this issue on May 1, 2021

    test: clear FLAKY designation for test-http2-pipe

    ...

    ed30e52

    test: clear flaky designation for test-stream-pipeline-http2

    ...

    102d12f
18. sjarmak

    added 2 commits that reference this issue on Jul 27, 2026

    http2: fix several serious bugs

    ...

    b11e19e

    http2: fix premature destroy

    ...

    7b6c428