镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

Missing exports : TLSv1_2_client_method, TLSv1_2_server_method #20369

Closed
Closed
Missing exports : TLSv1_2_client_method, TLSv1_2_server_method#20369
Labels
addonsIssues and PRs related to native addons.buildIssues and PRs related to Node.js builds or CI infrastructure.opensslIssues and PRs related to the OpenSSL dependency.windowsIssues and PRs related to the Windows platform.

Description

@d3x0r
d3x0r
opened on Apr 27, 2018

Version: 10.0.0
Platform: Win32-x64
Subsystem:

TLSv1_2_client_method and TLSv1_2_server_method are not exported.

there is TLS_client_method() and TLS_server_method(); but then node versions previous to 10 don't export that, but instead export the previous methods.

As a workaround - going to investigate a node version definition to #ifdef the code.

Activity

  1. d3x0r
    changed the title [-]Missing exports : TLSv1_2_client_methodm, TLSv1_2_server_method[/-] [+]Missing exports : TLSv1_2_client_method, TLSv1_2_server_method[/+] on Apr 27, 2018
  2. addaleax
    added
    windowsIssues and PRs related to the Windows platform.
    opensslIssues and PRs related to the OpenSSL dependency.
    addonsIssues and PRs related to native addons.
    on Apr 27, 2018

  3. addaleax commented on Apr 27, 2018

    @addaleax
    addaleax
    on Apr 27, 2018
    Member

    Just for clarity: What you are saying is that these symbols are not available to addons on Windows when they should be?

  4. d3x0r commented on Apr 27, 2018

    @d3x0r
    d3x0r
    on Apr 27, 2018
    ContributorAuthor

    They previously were available, so addons can link to and use the same version of OpenSSL as node.

    Edit: very annoying to workaround; the code that links against most of OpenSSL doesn't itself know about node.h (node_version.h) and it's not an issue with OpenSSL itself; that and I no longer get to control 'only 1.2' instead of 'best available'

    Edit2: Node-gyp doesn't seem to have/get the node version to pass to projects; I can get that with cmake-js but was trying to support both (for those that don't have cmake for some odd reason). So I can't even pass it a define when compiling to specify the NODE_MAJOR_VERSION.

  5. bnoordhuis commented on Apr 28, 2018

    @bnoordhuis
    bnoordhuis
    on Apr 28, 2018
    Member

    Should be easy to fix. @d3x0r Does this patch work for you?

    diff --git a/node.gyp b/node.gyp
index ba65eafee9..694c3e86d6 100644
--- a/node.gyp
+++ b/node.gyp
@@ -594,7 +594,7 @@
               # Categories to export.
               '-CAES,BF,BIO,DES,DH,DSA,EC,ECDH,ECDSA,ENGINE,EVP,HMAC,MD4,MD5,'
               'PSK,RC2,RC4,RSA,SHA,SHA0,SHA1,SHA256,SHA512,SOCK,STDIO,TLSEXT,'
-              'FP_API',
+              'FP_API,TLS1_2_METHOD',
               # Defines.
               '-DWIN32',
               # Symbols to filter from the export list.
  6. bnoordhuis
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Apr 28, 2018

  7. bnoordhuis commented on Apr 30, 2018

    @bnoordhuis
    bnoordhuis
    on Apr 30, 2018
    Member

    @d3x0r Any luck with that patch?

  8. d3x0r commented on Apr 30, 2018

    @d3x0r
    d3x0r
    on Apr 30, 2018
    ContributorAuthor

    Applied to version tagged 10.0.0
    And ... I dunno; it's not building.

      v8_inspector_copy_protocol_to_intermediate_folder
  cp: cannot create regular file `H:\\dev2\\node\\Release\\obj\\global_intermediate/deps\\v8\\src\\inspector\\js_protocol.pdl': No such file or directory
C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 1. [H:\dev2\n
ode\v8_inspector_compress_protocol_json.vcxproj]
  v8_libbase.vcxproj -> H:\dev2\node\Release\lib\v8_libbase.lib
  v8_libplatform.vcxproj -> H:\dev2\node\Release\lib\v8_libplatform.lib
  v8_libsampler.vcxproj -> H:\dev2\node\Release\lib\v8_libsampler.lib
  zlib.vcxproj -> H:\dev2\node\Release\lib\zlib.lib
Attempting to cancel the build...
C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(1074,5): error MSB6006: "Lib.exe" exited with code -1073741510.
 [H:\dev2\node\deps\openssl\openssl.vcxproj]
Terminate batch job (Y/N)?
^C

H:\dev2\node>dir release\obj\global_intermediate\deps\
The system cannot find the file specified.

    even cleaned everything from old builds so it would build clean... but no joy; I don't know.

    if you can get a node 10.0.0 to build; the node.lib should contain

    TLSv1_2_server_method TLSv1_2_client_method

    should be able to be found in clear text

  9. addaleax commented on Apr 30, 2018

    @addaleax
    addaleax
    on Apr 30, 2018
    Member

    @d3x0r I’m not sure but that might be caused by 2b85127. Can you revert that locally and try again? I don’t understand why it would fail for you but not in CI, but there’s a decent chance it’s causing that issue

  10. d3x0r commented on Apr 30, 2018

    @d3x0r
    d3x0r
    on Apr 30, 2018
    ContributorAuthor
    • 2018-04-24
      committed 5 days ago (I think that is after the tag I have?) Commits on Apr 27, 2018

    That's after V10.0.0 tag.

    SHA-1: cf41627

    • 2018-04-24, Version 10.0.0 (Current)

    I guess it's not that long ago; I can just build against head...

  11. addaleax commented on Apr 30, 2018

    @addaleax
    addaleax
    on Apr 30, 2018
    Member

    @d3x0r Yes, might even be the case that that fixes the problem for you then. 😄 The patch completely changed the mechanism of the copy operation that’s failing there, so I just thought it would be related to that

  12. d3x0r commented on Apr 30, 2018

    @d3x0r
    d3x0r
    on Apr 30, 2018
    ContributorAuthor

    Yes that change restores the two missing methods that I know of :) (clicked wrong button close and commented)

  13. d3x0r
    closed this as completedon Apr 30, 2018

  14. 18 remaining items

  15. refack commented on Nov 12, 2018

    @refack
    refack
    on Nov 12, 2018
    Contributor

    Hello @d3x0r,
    I'll see what I can do. If I can formulate a way to test this, and we figure out what is causing it, we will do our best to fix it, regardless of if the issue is open or closed.

  16. refack
    self-assigned this
    on Nov 12, 2018

  17. d3x0r commented on Nov 12, 2018

    @d3x0r
    d3x0r
    on Nov 12, 2018
    ContributorAuthor

    node-gyp configure build

    // warning - casting from the definition in the header, to an int....
m:\tmp\node_test\test.c(4): warning C4311: 'type cast': pointer truncation from 'const SSL_METHOD *(__cdecl *)(void)' to 'int' [M:\tmp\node_test\build\test_tls_method.vcxproj]

// and then it fails to link.
test.obj : error LNK2001: unresolved external symbol TLSv1_2_server_method [M:\tmp\node_test\build\test_tls_method.vcxproj]
M:\tmp\node_test\build\Release\test_tls_method.node : fatal error LNK1120: 1 unresolved externals [M:\tmp\node_test\build\test_tls_method.vcxproj]

    binding.gyp

    {
  "targets": [
    {
      "target_name": "test_tls_method",
      'win_delay_load_hook': 'false',      
      "sources": [ "test.c",
          ],
    }
  ],
}

    test.c

    #include <openssl/ssl.h>

int main( void ) {
   return (int)TLSv1_2_server_method;
}

    Could make it a gist instead....

  18. d3x0r commented on Nov 12, 2018

    @d3x0r
    d3x0r
    on Nov 12, 2018
    ContributorAuthor

    #20369 (comment)
    this worked before...

  19. refack commented on Nov 12, 2018

    @refack
    refack
    on Nov 12, 2018
    Contributor

    Thanks! This will surely help. I hope to get to it tomorrow.

  20. refack commented on Nov 13, 2018

    @refack
    refack
    on Nov 13, 2018
    Contributor

    So the problem is that the TLSv1_2_* were deprecated in openSSL_1_1:

    node/deps/openssl/openssl/util/libssl.num

    Line 157 in 49b0f7f

    TLSv1_server_method 158 1_1_0 EXIST::FUNCTION:DEPRECATEDIN_1_1_0,TLS1_METHOD

    PR - #24329

  21. refack
    reopened this on Nov 13, 2018

  22. richardlau commented on Feb 7, 2019

    @richardlau
    richardlau
    on Feb 7, 2019
    Member

    Opened #25991.

  23. richardlau
    added a commit that references this issue on Feb 7, 2019

    build: export deprecated OpenSSL symbols on Windows

    cb8a55e
  24. refack
    removed their assignment
    on Feb 7, 2019
  25. danbev
    added a commit that references this issue on Feb 11, 2019

    build: export deprecated OpenSSL symbols on Windows

    fcaeb1f
  26. targos
    added a commit that references this issue on Feb 11, 2019

    build: export deprecated OpenSSL symbols on Windows

    d5d163d

  27. richardlau commented on Feb 14, 2019

    @richardlau
    richardlau
    on Feb 14, 2019
    Member

    Fixed by fcaeb1f.

    Released in Node.js 11.10.0 (d5d163d8b9).

  28. richardlau
    closed this as completedon Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    addonsIssues and PRs related to native addons.buildIssues and PRs related to Node.js builds or CI infrastructure.opensslIssues and PRs related to the OpenSSL dependency.windowsIssues and PRs related to the Windows platform.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions