镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

mips failures for parallel/test-buffer-write(float|double) #20336

Description

@kapouer

When building nodejs 10.0.0 on this debian build server
these tests fail:
parallel/test-buffer-writefloat
parallel/test-buffer-writedouble

full log here

Activity

  1. kapouer commented on Apr 26, 2018

    @kapouer
    ContributorAuthor

    Other logs are available here. It is probably worth waiting the mipsel build before investigating.

  2. kapouer commented on Apr 26, 2018

    @kapouer
    ContributorAuthor

    Two other tests fail on mips arch:
    sequential/test-performance
    parallel/test-cli-node-options

    (all failures related to eslint are because there's no eslint module around).

  3. richardlau commented on Apr 27, 2018

    @richardlau
    Member

    (all failures related to eslint are because there's no eslint module around).

    Looks like we missed some tests in #18807.

  4. added
    mipsIssues and PRs related to the MIPS architecture.
    on Apr 27, 2018
  5. richardlau commented on Apr 27, 2018

    @richardlau
    Member

    #20372 should address the eslint failures.

  6. BridgeAR commented on Apr 27, 2018

    @BridgeAR
    Member

    @kapouer would you be so kind and run this once for me on mips and show me the output:

    const buffer = Buffer.alloc(8);
    buffer.writeDoubleBE(NaN, 0);
    console.log(buffer);
  7. kapouer commented on Apr 27, 2018

    @kapouer
    ContributorAuthor

    Unfortunately i can't run the code on the same server, i can have access only to that server. Where it results in (for both node 8.11 and 10.0):

    > const buffer = Buffer.alloc(8);
    undefined
    > buffer.writeDoubleBE(NaN, 0);
    8
    > console.log(buffer);
    <Buffer 7f f7 ff ff ff ff ff ff>
    
  8. BridgeAR commented on Apr 27, 2018

    @BridgeAR
    Member

    @kapouer thanks a lot. Fix incoming.

  9. BridgeAR commented on Apr 28, 2018

    @BridgeAR
    Member

    Now there is only the CLI test that should still fail. The question is what option it is that is not implemented. I guess it is --perf-prof. @kapouer would you mind checking that out?

  10. kapouer commented on Apr 28, 2018

    @kapouer
    ContributorAuthor

    Sure ! Indeed --perf-prof breaks with

    node --perf-prof
    #
    # Fatal error in , line 0
    # unimplemented code
    #
    #
    #
    #FailureMessage Object: 0x7f97d284Trace/breakpoint trap
    
    
  11. BridgeAR commented on Apr 28, 2018

    @BridgeAR
    Member

    @kapouer would you be so kind and test the tests with #20377 applied? All but the eslint tests should pass with that patch.

  12. kapouer commented on Apr 28, 2018

    @kapouer
    ContributorAuthor

    @BridgeAR both failures (buffer NaN and --perf-prof) fail on mipsel too when testing with nodejs 8.11.

  13. BridgeAR commented on Apr 28, 2018

    @BridgeAR
    Member

    With the NaN failures I guess you mean the value is represented as <Buffer 7f f7 ff ff ff ff ff ff>? That is expected and has something to do with mips and not with Node.js. We just have to fix the test again.

  14. richardlau commented on May 8, 2018

    @richardlau
    Member

    Failing tests addressed between #20372 and #20377.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    mipsIssues and PRs related to the MIPS architecture.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions