Repository navigation
mips failures for parallel/test-buffer-write(float|double) #20336
Description
Activity
Other logs are available here. It is probably worth waiting the mipsel build before investigating.
Two other tests fail on mips arch:
sequential/test-performance
parallel/test-cli-node-options(all failures related to eslint are because there's no eslint module around).
(all failures related to eslint are because there's no eslint module around).
Looks like we missed some tests in #18807.
- addedmipsIssues and PRs related to the MIPS architecture.Issues and PRs related to the MIPS architecture.
on Apr 27, 2018 #20372 should address the eslint failures.
@kapouer would you be so kind and run this once for me on mips and show me the output:
const buffer = Buffer.alloc(8); buffer.writeDoubleBE(NaN, 0); console.log(buffer);
Unfortunately i can't run the code on the same server, i can have access only to that server. Where it results in (for both node 8.11 and 10.0):
> const buffer = Buffer.alloc(8); undefined > buffer.writeDoubleBE(NaN, 0); 8 > console.log(buffer); <Buffer 7f f7 ff ff ff ff ff ff>@kapouer thanks a lot. Fix incoming.
Now there is only the CLI test that should still fail. The question is what option it is that is not implemented. I guess it is
--perf-prof. @kapouer would you mind checking that out?Sure ! Indeed
--perf-profbreaks withnode --perf-prof # # Fatal error in , line 0 # unimplemented code # # # #FailureMessage Object: 0x7f97d284Trace/breakpoint trap@BridgeAR both failures (buffer NaN and --perf-prof) fail on mipsel too when testing with nodejs 8.11.
With the NaN failures I guess you mean the value is represented as
<Buffer 7f f7 ff ff ff ff ff ff>? That is expected and has something to do with mips and not with Node.js. We just have to fix the test again.- added a commit that references this issue
on May 8, 2018
When building nodejs 10.0.0 on this debian build server
these tests fail:
parallel/test-buffer-writefloat
parallel/test-buffer-writedouble
full log here