Repository navigation
Need backward compatibility to use http1 on Http2Server #18554
Description
- Version: 9.5.0 (Current)
- Platform: Any
- Subsystem: http2
Details:
- I was experimenting with http2 on fastify NodeJS Server by following this doc
- Once http2 is out of experimental phase in Node v10, I'm planning to use its plain text version for communication between microservices.
- For backward compatibility, I noticed that http2 allows http1 connection for
Http2SecureServernode/lib/internal/http2/core.js
Lines 2456 to 2457 in 6d84ece
- However, I couldn't find an option to pass
allowHTTP1in options forHttp2Server
node/lib/internal/http2/core.js
Line 2529 in 6d84ece
Since microservices are updated independently of each other, we need a way to provide backward compatibility for http2 plain text server. Is there a plan to provide such option for Http2Server?
Activity
trivikr commentedon Feb 8, 2018
Any update on this request?
devsnek commentedon Feb 8, 2018
cc @nodejs/http2
jasnell commentedon Feb 8, 2018
This is not yet possible with plain text http2 because the fallback mechanism depends entirely on the use of the ALPN tls extension.
Working on this is not currently in plan for me but I'm happy to review PRs if anyone wants to tackle it
trivikr commentedon Feb 8, 2018
I'd written some unit tests for NodeJS HTTP/2 in the past, and have an idea about how core.js works.
I can take this up. Any tips/suggestions on where to start wrt ALPN?
mcollina commentedon Feb 8, 2018
ALPN is already supported, it is the mechanism to support both HTTP/1.1 and HTTP/2 over the secure channel. Basically ALPN is used to kickstart the connection.
Upgrading from a plain text HTTP1 to HTTP2 would mean to use a similar flow to what is used for websockets (check out https://www.npmjs.com/package/ws) to upgrade the socket.
It might very well be possible that this flow could happen 80% in the ecosystem but we would need a little bit of support from Node core. This would be my preferred path.
I'm also ok in implement it fully within Node.js itself.
jasnell commentedon Aug 10, 2018
At this point in time, there's really no plan to implement this in core. The current implementation should not preclude anyone from providing an implementation that uses a similar http/1 upgrade path as is used by bootstrapping websockets.