Repository navigation
Bikeshedding question: new home for V8's GYP files? #18262
Description
As you all might know, Chrome has moved off GYP in favor of GN as build system. V8 has followed that move, but kept maintaining gyp configs for longer than Chrome requires, mostly for Node.js.
In the past weeks I have, as planned, implemented a GYP/GN bridge so that V8 as Node.js' dependency can be built with GN. This means that in order to test V8 against Node.js, the V8 team no longer has to maintain GYP.
We will probably be getting rid of GYP configs in upstream V8 in this quarter. Node.js will need to take ownership over these files, at least before it has found an alternative to GYP.
Question is, where should these files reside?
- Should they stay in
deps/v8/even though they no longer exist in upstream V8? I'm sure we can make this work without affecting updating V8 too much by tweaking.gitignorefiles. - Or should they live in node core, for example
toolsor a newbuildsubfolder?
I don't have any strong opinion on this, but would like to experiment with this to prepare for handover.
Activity
addaleax commentedon Jan 19, 2018
/cc @nodejs/v8
Afaik we do maintain the other gypfiles (for e.g. zlib, c-ares, nghttp2) through the first way, i.e. in
deps/foo/even though they don’t exist upstream.ofrobots commentedon Jan 20, 2018
+1 for first option.
targos commentedon Jan 21, 2018
V8 gypfiles are currently scattered in many directories. If we go with option 1, is it possible to put them all in the same place?
hashseed commentedon Jan 23, 2018
Okay. I have begun moving gyp files into
v8/gypfiles. At some point I'll simply delete them from V8.mhdawson commentedon Feb 1, 2018
Sounds good to me.
targos commentedon Feb 23, 2018
GYP files are now out of V8 master. I added the necessary steps to handle this in
update-v8: https://github.com/targos/update-v8/blob/master/src/gypfiles.js