镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

please use less memory in test-zlib #17986

Closed
Closed
please use less memory in test-zlib#17986
Labels
testIssues and PRs related to Node.js core tests and test infrastructure.zlibIssues and PRs related to the zlib module and its compression dependencies.

Description

@kapouer
kapouer
opened on Jan 4, 2018

This line

node/test/parallel/test-zlib.js

Line 160 in 11dda69

const node = fs.createReadStream(process.execPath);

consumes a lot of memory during tests.
Some platforms will not have enough memory and will somewhat wrongfully fail the test.
Is it possible to load another file (than process.execPath) ?

Activity

  1. Trott
    added a commit that references this issue on Jan 5, 2018

    test: use smaller input file for test-zlib.js

    1c00fad

  2. Trott commented on Jan 5, 2018

    @Trott
    Trott
    on Jan 5, 2018
    Member

    Hi, @kapouer! Can you confirm that #17988 fixes this for your situation?

  3. maclover7
    added
    testIssues and PRs related to Node.js core tests and test infrastructure.
    zlibIssues and PRs related to the zlib module and its compression dependencies.
    on Jan 5, 2018

  4. kapouer commented on Jan 5, 2018

    @kapouer
    kapouer
    on Jan 5, 2018
    ContributorAuthor

    Thanks ! I'm just waiting for the mips build server (where it fails more often) to finish. Will confirm tomorrow UTC+1 :)

  5. kapouer commented on Jan 5, 2018

    @kapouer
    kapouer
    on Jan 5, 2018
    ContributorAuthor

    I confirm that the test pass now.

  6. jasnell
    closed this as completedin bf2e964on Jan 10, 2018
  7. evanlucas
    added a commit that references this issue on Jan 22, 2018

    test: use smaller input file for test-zlib.js

    8778090
  8. evanlucas
    added a commit that references this issue on Jan 30, 2018

    test: use smaller input file for test-zlib.js

    3456e61
  9. MylesBorins
    added 2 commits that reference this issue on Feb 27, 2018

    test: use smaller input file for test-zlib.js

    66a19cf

    test: use smaller input file for test-zlib.js

    16ef24b
  10. sjarmak
    added a commit that references this issue on Jul 27, 2026

    test: use smaller input file for test-zlib.js

    bf2e964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testIssues and PRs related to Node.js core tests and test infrastructure.zlibIssues and PRs related to the zlib module and its compression dependencies.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions