You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Debug build assertion failure in V8 for sequential/test-inspector-async-stack-traces-promise-then #17017
Testing out adding Debug builds to CI and I have some failures that need looking at that'll need someone cleverer than me.
Current master, fails via sequential/test-inspector-async-stack-traces-promise-then:
$ ./out/Debug/node test/sequential/test-inspector-async-stack-traces-promise-then
[test] Connecting to a child Node process
[test] Testing /json/list
[err] Debugger listening on ws://127.0.0.1:58956/bdb5e1e8-9a06-4d52-9d2b-ba331c6de620
[err] For help see https://nodejs.org/en/docs/inspector
[err]
[err] Debugger attached.
[err]
[test] Waiting for break1
[test] Waiting for break2
[err]
[err]
[err] #
[err] # Fatal error in ../deps/v8/src/inspector/v8-debugger.cc, line 831
[err] # Debug check failed: m_currentTasks.back() == task.
[err] #
[err]
Timed out waiting for matching notification (break on [eval]:9))
1
See https://chromium-review.googlesource.com/c/v8/v8/+/707058 and the discussion in it – essentially, we need to turn off the reporting of our own promise tracking to V8, or teach V8 to not track promises itself, or apply my 10-line fix to make sure the tracking ordering is correct.
Activity
rvagg commentedon Nov 14, 2017
Fails on Linux and macOS
hashseed commentedon Nov 14, 2017
@ak239
addaleax commentedon Nov 15, 2017
See https://chromium-review.googlesource.com/c/v8/v8/+/707058 and the discussion in it – essentially, we need to turn off the reporting of our own promise tracking to V8, or teach V8 to not track promises itself, or apply my 10-line fix to make sure the tracking ordering is correct.
inspector: no async tracking for promises
inspector: no async tracking for promises
inspector: no async tracking for promises
inspector: no async tracking for promises
inspector: no async tracking for promises