Repository navigation
Add a new label fast-track? #16877
Description
Activity
Can you put together a couple of sentence description for what 'fast-track' would mean ? I'm wondering if it is meant to just be informational, a request to get agreement that a PR can be fast tracked or if its also a request to jump in and help get it reviewed/landed quickly ?
I am leaning towrads "a request to get agreement that a PR can be fast tracked", meaning this should be landable after n approvals have been made (the number n needs discussion, of course). I will open a PR later to document this in the collaborator guide, that way it would be easier for us to discuss about the actual process (text changes).
Reacted by Anatoli PapirovskiI created the label. Without new wording in the collaborator guide, current policy is:
Trivial changes (e.g. those which fix minor bugs or improve performance without affecting API or causing other wide-reaching impact), and focused changes that affect only documentation and/or the test suite, may be landed after a shorter delay if they have multiple approvals.
So I would consider the use of this label as a declaration of intent so people can request to take it slow, and also for traceability of the decision process.
@joyeecheung since the fast-track label has been created, this can be closed, right? (wasn't sure, wanted to double check)
@maclover7 Yes, thanks for the reminder
We've decided in #16135 to fast-track certain types of PRs (mostly test-only and doc-only PRs), also we need to expedite some PR fixing regressions or CI from time to time as well, maybe we can just use a new label to make those decisions clearer? I am thinking about
fast-trackat the moment.Refs: https://github.com/joyeecheung/node-core-utils/pull/92
Refs: https://github.com/joyeecheung/node-core-utils/pull/94