Promise's domain property allows escaping VM #15673

Activity

1. TimothyGu

   added

   domainIssues and PRs related to the domain subsystem.Issues and PRs related to the domain subsystem.

   vmIssues and PRs related to the vm subsystem.Issues and PRs related to the vm subsystem.

   on Sep 29, 2017
2. bnoordhuis commented on Sep 29, 2017

   

   bnoordhuis

   on Sep 29, 2017

   Last edited by bnoordhuis

   Member

   More actions

   Doesn't really strike me as an issue. vm is not a security mechanism.

   edit: no opinion on whether promise hooks should be enabled or not.
3. TimothyGu commented on Sep 29, 2017

   

   TimothyGu

   on Sep 29, 2017

   MemberAuthor

   More actions

   vm is not a security mechanism.

   ... and I never said it was, but it has been the case until now that objects from another context can only be present in a vm context if the user explicitly adds things into the sandbox from another sandbox.

   ---

   I just realized the domain property is only added if domains are enabled, which is the case in the REPL. That softens the blow for me, but this still sounds like a bug.
4. TimothyGu

   closed this as completedin 8068577on Oct 4, 2017
5. addaleax

   added a commit that references this issue on Oct 12, 2017

   src: do not add .domain to promises in VM contexts

   ...

   8d727f1
6. TimothyGu

   added a commit that references this issue on Oct 22, 2017

   src: do not add .domain to promises in VM contexts

   ...

   3a7411f
7. evanlucas

   added a commit that references this issue on Oct 23, 2017

   src: do not add .domain to promises in VM contexts

   ...

   0b04869