Repository navigation
Windows - inspector - intermittent ? - inspector/test-bindings #15558
Description
Activity
@nodejs/platform-windows
Looking at https://ci.nodejs.org/view/All/job/node-daily-master/ , this has happened for 3 days (since September 20).
There's also `inspector/test-debug-end`.
not ok 442 inspector/test-debug-end --- duration_ms: 0.696 severity: fail stack: |- Test there's no crash stopping server that was not started Test there's no crash stopping server without connecting [err] Debugger listening on ws://127.0.0.1:63103/542e4e93-0081-41fd-a597-bf147ce898b0 [err] For help see https://nodejs.org/en/docs/inspector [err] Test there's no crash stopping server after connecting [test] Connecting to a child Node process [test] Testing /json/list [err] Debugger listening on ws://127.0.0.1:63104/cc5fdd8a-9fb6-4229-853f-3361070018df [err] For help see https://nodejs.org/en/docs/inspector [err] [err] Debugger attached. [err] Debugger listening on ws://127.0.0.1:63107/ede6f417-c23f-44e3-8f61-292d613b1dde [err] For help see https://nodejs.org/en/docs/inspector [err] { AssertionError [ERR_ASSERTION]: 42 === 3221225477 at testSessionNoCrash (c:\workspace\node-test-binary-windows\COMPILED_BY\vs2017\RUNNER\win2016\RUN_SUBSET\1\test\inspector\test-debug-end.js:35:3) at <anonymous> at process._tickCallback (internal/process/next_tick.js:188:7) generatedMessage: true, name: 'AssertionError [ERR_ASSERTION]', code: 'ERR_ASSERTION', actual: 42, expected: 3221225477, operator: '===' } 1
cc @nodejs/testing and @eugeneo perhaps
Here is another stack trace
not ok 441 inspector/test-bindings --- duration_ms: 0.234 severity: fail stack: |- Expecting warning to be emitted (node:5800) Error: We expect this c:\workspace\node-test-binary-windows\COMPILED_BY\vs2017\RUNNER\win2016\RUN_SUBSET\1\test\common\index.js:789 (err) => process.nextTick(() => { throw err; })); ^ AssertionError [ERR_ASSERTION]: [ 'Iteration 1 variable: i expected: 1 actual: 0', 'Iteration 2 variable: i expected: 2 actual: 1', 'Iteration 2 variable: a deepStrictEqual [] at testSampleDebugSession (c:\workspace\node-test-binary-windows\COMPILED_BY\vs2017\RUNNER\win2016\RUN_SUBSET\1\test\inspector\test-bindings.js:104:10) at doTests (c:\workspace\node-test-binary-windows\COMPILED_BY\vs2017\RUNNER\win2016\RUN_SUBSET\1\test\inspector\test-bindings.js:131:3) at <anonymous> at process._tickCallback (internal/process/next_tick.js:188:7) at Function.Module.runMain (module.js:643:11) at startup (bootstrap_node.js:187:16) at bootstrap_node.js:607:3 ...@joaocgreis it is probably a good idea to open a new issue for the other failure?
@BridgeAR they started at about the same time in the same subsystem, so they might be related. We can probably address them here until we figure out if they are related or not, but feel free to open another issue if you think that will help.
Reacted by Gibson FahnestockIs anyone actively looking at this? (Saw another one today and I'm looking at CI a lot less than usual, so a good chance there's lots more.) I'm hoping we can get CI reliably green in preparation for Code + Learn next week.
Is anyone actively looking at this? (Saw another one today and I'm looking at CI a lot less than usual, so a good chance there's lots more.) I'm hoping we can get CI reliably green in preparation for Code + Learn next week.
I'm trying to repro locally.
Reacted by Rich Trottping @nodejs/v8-inspector Any idea what might be causing these tests to fail on Windows? It would be good to have CI back to green for Code + Learn next week....
@refack - are you looking into it? I inspected the test case visually and feel like the test may not be deterministic (e.g. it relies on the variables order in the inspector response). I think V8 might shuffle the variables because of reasons (JIT, etc). I'm going to try and make the test more deterministic.
(Sorry, disregard my comment - does not seem to be the case. I still would like to take a look at this test case)
Reacted by Refael Ackermann23 remaining items
- added a commit that references this issue
on Oct 26, 2017 BTW: did you check that all accesses to libuv are thread safe?
I see this issue using the JS API (e.g. there's no second thread running, libuv is not used for anything). What I am seeing is that session is receiving repeat "Debugger.paused" notifications from the V8. Number of those repetition is same as the total number of the previous sessions + 1. E.g. if I open and close 2 sessions, third session I will be notified thrice.
It does not look like it is in V8 side of the Inspector too - it is a debug listener that fires the event multiple times, Inspector has a single session and properly dispatches the event there.
I suspect there's something funny with some object deregistering, so could it be some destructor is now "optimized out"?
I will update this bug when I have more information.
Reacted by Refael Ackermann and Benjamin GruenbaumThis is now
sequential/test-inspector-bindings, right?not ok 514 sequential/test-inspector-bindings # TODO : Fix flaky test --- duration_ms: 0.240 severity: flaky stack: |- Expecting warning to be emitted (node:6608) Error: We expect this c:\workspace\node-test-binary-windows\test\common\index.js:797 (err) => process.nextTick(() => { throw err; })); ^ AssertionError [ERR_ASSERTION]: [ 'Iteration 1 variable: i expected: 1 actual: 0', 'Iteration 2 variable: i expected: 2 actual: 1', 'Iteration 2 variable: a deepStrictEqual [] at testSampleDebugSession (c:\workspace\node-test-binary-windows\test\sequential\test-inspector-bindings.js:104:10) at doTests (c:\workspace\node-test-binary-windows\test\sequential\test-inspector-bindings.js:131:3) at <anonymous> at process._tickCallback (internal/process/next_tick.js:165:7) at Function.Module.runMain (module.js:703:11) at startup (bootstrap_node.js:195:16) at bootstrap_node.js:646:3 ...
Still open.
It seems like perhaps this should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.
Failure during run on un-related PR
https://ci.nodejs.org/job/node-test-binary-windows/11280/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=1/console