镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

fatal error: 'node_internals.h' file not found #15552

Closed
Closed
fatal error: 'node_internals.h' file not found#15552
Assignees
addaleax
Labels
addonsIssues and PRs related to native addons.confirmed-bugIssues and PRs for confirmed bugs.

Description

@AndreasMadsen
AndreasMadsen
opened on Sep 22, 2017
  • Version: 01c680b
  • Platform: MacOS X
  • Subsystem: addon

Running npm --nodedir=$NODE_BUILD_PATH install native-hdr-histogram causes the error:

/Users/Andreas/node/include/node/node_buffer.h:25:10: fatal error: 'node_internals.h' file not found
#include "node_internals.h"

I think we did something wrong in how we export or setup the headers. It appears to be caused by 290315a

Activity

  1. AndreasMadsen commented on Sep 22, 2017

    @AndreasMadsen
    AndreasMadsen
    on Sep 22, 2017
    MemberAuthor

    /cc @addaleax

  2. AndreasMadsen
    added
    addonsIssues and PRs related to native addons.
    on Sep 22, 2017

  3. richardlau commented on Sep 22, 2017

    @richardlau
    richardlau
    on Sep 22, 2017
    Member

    Suspect 290315a is the culprit. The refactor appears to have dropped the #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS guard.

  4. addaleax
    self-assigned this
    on Sep 22, 2017
  5. addaleax
    added a commit that references this issue on Sep 22, 2017

    src: do not include internals from node_buffer.h

    6dcf62c
  6. AndreasMadsen
    added
    confirmed-bugIssues and PRs for confirmed bugs.
    on Sep 22, 2017
  7. addaleax
    closed this as completedin 84063a7on Sep 22, 2017
  8. addaleax
    added a commit that references this issue on Sep 23, 2017

    src: do not include internals from node_buffer.h

    df18f2a
  9. jasnell
    added a commit that references this issue on Sep 25, 2017

    src: do not include internals from node_buffer.h

    24271a7
  10. sjarmak
    added a commit that references this issue on Jul 27, 2026

    src: do not include internals from node_buffer.h

    84063a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

addonsIssues and PRs related to native addons.confirmed-bugIssues and PRs for confirmed bugs.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions