Feature Request: mark tests flaky on FIPS

@Trott

See 8fae1e6#commitcomment-23583689

Currently tools/test.py only compares against env, which is defined as

        env = {
          'mode': mode,
          'system': utils.GuessOS(),
          'arch': vmArch,
        }

Where mode is release/debug, system is OS, and arch is ARCH.

We'd need to also have an option for FIPS, I guess that should be in env. Maybe a type? Type could be default, fips, or sharedlib (if we end up building a shared library as well we might want a sharedlib type).

cc/ @Trott @bajtos

If the buildbots were to set a NODE_BUILDBOT_TYPE environment variable, you could do this:

env = {
  # ...
  'type': os.getenv('NODE_BUILDBOT_TYPE', 'default'),
}

Would that work?

Well for the fips check you could just do node -p process.versions.openssl.includes('fips'). That would work in local builds as well.

I was thinking more about how to structure the env variable in python.

@gibfahn

Hello @gibfahn and others,

I had a small conversation with @Trott offline and I think I understand this issue. I would like to help out with this one if you all are okay with it.

@komawar

@komawar please go ahead and open a PR. That is always best.

test: Enable specifying flaky tests on fips

Navigation Menu

Repository navigation

Feature Request: mark tests flaky on FIPS #14746

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Feature Request: mark tests flaky on FIPS #14746

Description

Activity

bnoordhuis commented on Sep 21, 2017

gibfahn commented on Sep 22, 2017

komawar commented on Oct 10, 2017

BridgeAR commented on Oct 10, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions