dns: occasionally crashing in resolve4 and setServers

Version: v9.0.0-pre (master)
Platform: Darwin zanarpro 16.6.0 Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64 x86_64 i386 MacBookPro11,3 Darwin
Subsystem: c-ares

Here's the code:

// under test folder
const common = require('../common');
const dns = require('dns');

dns.resolve4('google.com', common.mustCall(function(/* err, nameServers */) {
  dns.setServers([ '8.8.8.8' ]);
}));

dns.resolve4('google.com', common.mustCall(function() {
  // do nothing...
}));

And the Node.js will occasionally crash with:

Assertion failed: (ares__is_list_empty(&server->queries_to_server)), function ares__destroy_servers_state, file ../deps/cares/src/ares_destroy.c, line 102.

I'm going to fix this issue. I think I know where the problem is, but I need some time to fix it.

dns: fix crash while setting server during query

I monkey patched dns module to fix that. If anyone needs to keep unpatched Node version and doesn't want the crashes - please use my fix.
More information here: https://github.com/dzek69/node-dns-bugfix

BTW: It's a duplicate of #894.

dns: fix crash while setting server during query

Navigation Menu

Repository navigation

dns: occasionally crashing in resolve4 and setServers #14734

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

dns: occasionally crashing in resolve4 and setServers #14734

Description

Activity

XadillaX commented on Aug 10, 2017

dzek69 commented on Jun 16, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions