repl: '...' should not be detected as REPL keyword #14426

Activity

1. silverwind

   added

   good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.

   replIssues and PRs related to the REPL subsystem.Issues and PRs related to the REPL subsystem.

   on Jul 22, 2017
2. shivanth commented on Jul 22, 2017

   

   shivanth

   on Jul 22, 2017

   Contributor

   More actions

   I take this up ...

   👍React with 👍1Reacted by silverwind
3. shivanth

   added a commit that references this issue on Jul 23, 2017

   repl:Do not consider `...` as a REPL command

   ...

   d5b6ec8
4. shivanth commented on Jul 23, 2017

   

   shivanth

   on Jul 23, 2017

   Contributor

   More actions

   I've modified REPL so that ... is not considered as a REPL keyword anymore.
   I'm seeing different behviours on REPL of node inspect -p and node. On the inspector I see the expected

   debug> ...[]
   ...[]
   ^^^
   
   SyntaxError: Unexpected token ...
   

   But on node REPL, I see that it's expecting more input

   > ...[]
   ...
   

   What could be the reason ?
5. refack commented on Jul 23, 2017

   

   refack

   on Jul 23, 2017

   Contributor

   More actions

   @shivanth I'm not sure ...[] is valid expression. [...[]] is...
   The inspect console is a special REPL implemented by node-inspect so it behaves different than the regular REPL. They are both trying to say that ...[] is an invalid expression.

   • chrome
     
   • cli:

   d:\code\node-cur$ node -e "...[]"
   [eval]:1
   ...[]
   ^^^
   
   SyntaxError: Unexpected token ...
       at createScript (vm.js:74:10)
       at Object.runInThisContext (vm.js:116:10)
       at Object.<anonymous> ([eval]-wrapper:6:22)
       at Module._compile (module.js:569:30)
       at evalScript (bootstrap_node.js:432:27)
       at startup (bootstrap_node.js:139:9)
       at bootstrap_node.js:575:3
   
   d:\code\node-cur$ node -e "(...[])"
   [eval]:1
   (...[])
    ^^^
   
   SyntaxError: Unexpected token ...
       at createScript (vm.js:74:10)
       at Object.runInThisContext (vm.js:116:10)
       at Object.<anonymous> ([eval]-wrapper:6:22)
       at Module._compile (module.js:569:30)
       at evalScript (bootstrap_node.js:432:27)
       at startup (bootstrap_node.js:139:9)
       at bootstrap_node.js:575:3
   
   d:\code\node-cur$ node -e "[...[]]"
   
   d:\code\node-cur$ echo %ERRORLEVEL%
   0
6. refack commented on Jul 23, 2017

   

   refack

   on Jul 23, 2017

   Contributor

   More actions

   P.S. IMHO what you showed in the comment #14426 (comment) above is the correct behaviour
7. Fishrock123

   added

   confirmed-bugIssues and PRs for confirmed bugs.Issues and PRs for confirmed bugs.

   on Jul 24, 2017
8. shivanth commented on Jul 24, 2017

   

   shivanth

   on Jul 24, 2017

   Contributor

   More actions

   @refack , you mean to say that the REPL should wait for more input after seeing ...[] ?
9. refack commented on Jul 24, 2017

   

   refack

   on Jul 24, 2017

   Contributor

   More actions

   @refack , you mean to say that the REPL should wait for more input after seeing ...[] ?

   I think so... That's how the REPL behaves with invalid expressions:

   > var o = {a:1}}
   ...
   
10. silverwind commented on Jul 24, 2017

    

    silverwind

    on Jul 24, 2017

    ContributorAuthor

    More actions

    That's how the REPL behaves with invalid expressions

    Which is pretty weird in itself imho, but yes, this seems to be the correct behaviour right now.
11. silverwind

    closed this as completedin 46d3ff2on Jul 29, 2017
12. addaleax

    added a commit that references this issue on Jul 29, 2017

    repl: do not consider `...` as a REPL command

    ...

    1a5927f
13. shivanth

    added a commit that references this issue on Aug 18, 2017

    repl: do not consider `...` as a REPL command

    ...

    1e07864
14. MylesBorins

    added a commit that references this issue on Sep 19, 2017

    repl: do not consider `...` as a REPL command

    ...

    362a7c0