v8::internal::JSReceiver::DefineOwnProperty exception cause a crash #14335

Activity

1. TimothyGu commented on Jul 18, 2017

   

   TimothyGu

   on Jul 18, 2017

   Member

   More actions

   Can you provide a reproducible test case?
2. kisondu commented on Jul 18, 2017

   

   kisondu

   on Jul 18, 2017

   Last edited by targos

   Author

   More actions

   @TimothyGu
   The probability of 50% appears. I suspect that isolate usage is problematic，trouble to help me check the following code，thanks

   void AsyncDBWrap::PushQuery(const v8::FunctionCallbackInfo<v8::Value>& args)
   {
   	Isolate* isolate = args.GetIsolate();
   	
       AsyncDBWrap* db_wrap = ObjectWrap::Unwrap<AsyncDBWrap>(args.This());
       if (!db_wrap || !db_wrap->m_db)
       {
   		isolate->ThrowException(Exception::TypeError(String::NewFromUtf8(isolate, "err parameters for NewRouter")));
   		args.GetReturnValue().Set(Number::New(isolate, -1));
   		return;
       }
   
       if (!args[0]->IsString())
       {
   		isolate->ThrowException(Exception::TypeError(String::NewFromUtf8(isolate, "push query parameters error")));
   		args.GetReturnValue().Set(Number::New(isolate, -2));
   		return;
       }
   
       std::string sql = std::string(*String::Utf8Value(args[0]->ToString()));
       bool cb_able = true;
       ResHandler cb = nullptr;
       
       if (args.Length() >= 2)
       { 
           uint32_t cbId = ++m_cbOriId;
           Persistent<Function> *f = nullptr;
           if (args[1]->IsFunction())
           {
   			f = new Persistent<Function>(isolate, Local<Function>::Cast(args[1]));
           }
           else if (args[1]->IsBoolean() && args[2]->IsFunction())
           {
               cb_able = args[1]->BooleanValue();
   			f = new Persistent<Function>(isolate, Local<Function>::Cast(args[2]));
           }
           else
           {
   			isolate->ThrowException(Exception::TypeError(String::NewFromUtf8(isolate, "push query parameters error")));
   			args.GetReturnValue().Set(Number::New(isolate, -3));
   			return;
           }
   
           m_cbs.insert(std::make_pair(cbId, f));
   
   
           cb = [cbId](const std::string& err, ResultSetPtr& resPtr, uint64_t count, uint64_t time) -> void
           {
   			Isolate* isolate = Isolate::GetCurrent();
   			EscapableHandleScope handler_scope(isolate);
   
   
               //Local<Object> context = Context::GetCurrent()->Global();
   			Local<Object> context = isolate->GetCurrentContext()->Global();
               const int argc = 4;
               Local<Array> arr = Array::New(isolate, resPtr->rowsCount());
               bool ret = GetV8Res(resPtr, arr);
               if (ret)
               {
                   Handle<Value> argv[argc] = { String::NewFromUtf8(isolate, err.c_str()), handler_scope.Escape(arr), Number::New(isolate,count), Number::New(isolate, time) };
   				Local<Function>::New(isolate, *m_cbs[cbId])->Call(context, argc, argv);
               }
               else
               {
                   Handle<Value> argv[argc] = { String::NewFromUtf8(isolate, "get result error!"), Null(isolate), Null(isolate), Null(isolate) };
   				Local<Function>::New(isolate, *m_cbs[cbId])->Call(context, argc, argv);
               }
   
   			m_cbs[cbId]->Reset();
   			delete m_cbs[cbId];
               m_cbs.erase(cbId);
   
           };
       }
   
   	args.GetReturnValue().Set(Number::New(isolate, db_wrap->m_db->PushQuery(sql, cb, cb_able)));
   }
   
   void AsyncDBWrap::Tick(const v8::FunctionCallbackInfo<v8::Value>& args)
   {
   	Isolate *isolate = args.GetIsolate();
   	bool hasErr = false;
   
       AsyncDBWrap* db_wrap = ObjectWrap::Unwrap<AsyncDBWrap>(args.This());
       if (!db_wrap || !db_wrap->m_db)
       {
   		isolate->ThrowException(Exception::TypeError(String::NewFromUtf8(isolate, "Tick error")));		
   		args.GetReturnValue().Set(Boolean::New(isolate, !hasErr));
   		return;
       }
   
       uint32_t ec = db_wrap->m_db->OnTickResult();
       std::string ec_what;
   
       if (ec == MySqlServerGoneAway)
       {
           ec_what = "MySql server has gone away, reconnect soon.";
           hasErr = true;
       }
       else if (ec)
       {
           ec_what = "db error: " + std::to_string(ec);
           hasErr = true;
       }
   
       if (hasErr)
       {
           if (args[0]->IsFunction())
           {
               const int argc = 1;
               Handle<Value> argv[argc] = { String::NewFromUtf8(isolate, ec_what.c_str()) };
               Handle<Function>::Cast(args[0])->Call(isolate->GetCurrentContext()->Global(), argc, argv);
           }
           else
           {
   			isolate->ThrowException(Exception::TypeError(String::NewFromUtf8(isolate, "Tick error")));
   			args.GetReturnValue().Set(Boolean::New(isolate, !hasErr));
   			return;
           }
       }
   
       //db_wrap->m_dbTask.tick();
   	args.GetReturnValue().Set(Boolean::New(isolate, !hasErr));
   	return;
   }
3. bnoordhuis commented on Jul 18, 2017

   

   bnoordhuis

   on Jul 18, 2017

   Member

   More actions

   Please move this over to https://github.com/nodejs/help/issues. This bug tracker is for reporting bugs in node.js, not general support.
4. bnoordhuis

   closed this as completedon Jul 18, 2017
5. bnoordhuis

   added

   invalidIssues and PRs that are invalid.Issues and PRs that are invalid.

   questionIssues asking questions about Node.js.Issues asking questions about Node.js.

   on Jul 18, 2017