child_process,Windows: fix docs for spawn({shell})

Version: *
Platform: Windows
Subsystem: child_process

https://nodejs.org/api/child_process.html#child_process_child_process_spawn_command_args_options erronously states that cmd.exe is the default shell for windows, while infact it's process.env.ComSpec.
The same goes for:

/cc @nodejs/platform-windows @nodejs/documentation

This is one of many problems arising from setting weird environments for child processes.

Technically, the documentation is not entirely incorrect. Microsoft specifies that COMSPEC must always contain the path to cmd.exe, at least for the root environment, so as long as that is true, the documentation is correct. It is still worth changing this in the documentation as - sadly - it is not always true for child processes...

I think we should say that the value defaults to COMSPEC, and if that is not set, cmd.exe is used.

Ref #14157

doc: fixes default shell in child_process.md

Navigation Menu

Repository navigation

child_process,Windows: fix docs for `spawn({shell})` #14156

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

child_process,Windows: fix docs for spawn({shell}) #14156

Description

Activity

refack commented on Jul 10, 2017

tniessen commented on Jul 10, 2017

cjihrig commented on Jul 10, 2017

tniessen commented on Jul 10, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

child_process,Windows: fix docs for `spawn({shell})` #14156