You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test: test/parallel/test-fs-write-sync.js failed when node < 7.2.0 #13899
Platform: Darwin jacksontian-air 16.6.0 Darwin Kernel Version 16.6.0: Fri Apr 14 16:21:16 PDT 2017; root:xnu-3789.60.24~6/RELEASE_X86_64 x86_64
Subsystem: fs
# the v7.2.0 is OK.
$ ~/.tnvm/versions/node/v7.2.0/bin/node ~/git/nodejs/test/parallel/test-fs-write-sync.js
# the versions before v7.2.0 is NOT OK.
$ ~/.tnvm/versions/node/v6.11.0/bin/node ~/git/nodejs/test/parallel/test-fs-write-sync.js
assert.js:81
throw new assert.AssertionError({
^
AssertionError: false == true
at Object.<anonymous> (/Users/jacksontian/git/nodejs/test/parallel/test-fs-write-sync.js:57:10)
at Module._compile (module.js:570:32)
at Object.Module._extensions..js (module.js:579:10)
at Module.load (module.js:487:32)
at tryModuleLoad (module.js:446:12)
at Function.Module._load (module.js:438:3)
at Module.runMain (module.js:604:10)
at run (bootstrap_node.js:389:7)
at startup (bootstrap_node.js:149:9)
at bootstrap_node.js:504:3
I try to find out which commit fix it in v7.2.0, but failed.
Since the fix landed, going to close out this issue. If the tests starts to become flaky again, or if this needs to stay open, please reopen the issue :)
Activity
vsemozhetbyt commentedon Jun 25, 2017
@JacksonTian #7856?
vsemozhetbyt commentedon Jun 25, 2017
It seems this is the backport for v6.x: #13179
maclover7 commentedon Dec 25, 2017
Since the fix landed, going to close out this issue. If the tests starts to become flaky again, or if this needs to stay open, please reopen the issue :)