Repository navigation
test: test-http(s)-set-timeout-server.js tests should be more similar #13588
Copy link
Copy link
Closed
Labels
good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.httpIssues and PRs related to the http subsystem.Issues and PRs related to the http subsystem.httpsIssues and PRs related to the https subsystem.Issues and PRs related to the https subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
Description
Activity
- addedgood first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.httpIssues and PRs related to the http subsystem.Issues and PRs related to the http subsystem.httpsIssues and PRs related to the https subsystem.Issues and PRs related to the https subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
on Jun 9, 2017 - changed the title
[-]test-http(s)-set-timeout-server.js tests should be more similar[/-][+]test: test-http(s)-set-timeout-server.js tests should be more similar[/+]on Jun 9, 2017 I would like to work on this :)
Reacted by Gibson FahnestockI would like to work on this :)
Let us know if you need any help.
- added a commit that references this issue
on Jun 19, 2017 Copying @mscdex's comment from #13625 over here:
There are some other minor differences that could be made consistent, for example:
- server.listen() vs server.listen(0, )
- missing assert.ok(s instanceof http.OutgoingMessage);-type asserts in the https test file
- missing common.mustCall()s in the https test file (e.g. around server.listen() callback -- compared to http test file) and the http test file (e.g. around request handler callback -- compared to https test file)
- etc..
Really the only differences that should exist between the two should be the references to the http module vs the https module, use of net.connect() vs tls.connect(), and https.Server-specific stuff, like the passing of the cert, etc. configuration to https.createServer(). Everything else should be the same.
- added 2 commits that reference this issue
on Jun 20, 2017 - added a commit that references this issue
on Jun 24, 2017 - added a commit that references this issue
on Jun 26, 2017 4 remaining items
- added a commit that references this issue
on Jul 3, 2017 - added 2 commits that reference this issue
on Jul 11, 2017 - added 2 commits that reference this issue
on Jul 18, 2017 - added a commit that references this issue
on Jul 19, 2017 - added 9 commits that reference this issue
on Aug 14, 2017
Metadata
Metadata
Assignees
Labels
good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.httpIssues and PRs related to the http subsystem.Issues and PRs related to the http subsystem.httpsIssues and PRs related to the https subsystem.Issues and PRs related to the https subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.
Both of these tests contain unique changes that should copied to the other.
Examples:
test-http-set-timeout-server.js has a
secReceivedcheck inserverResponseTimeoutWithPipeline()that was added to prevent flakiness, but this does not exist in the https counterpart.test-https-set-timeout-server.js utilizes
common.mustCall(),common.mustNotCall(), etc., while the http counterpart still utilizes the old method of checking flags on exit of the process.