Sometimes REPL cannot display the result

Version: 6.10.1
Platform: Windows 10 x64
Subsystem: happens both cmd.exe and powershell

In node REPL mode, when I execute a function, sometimes the result cannot be displayed. Refer as the below screenshot:

It sounds like GetVersionEx() is failing but I can't fathom why. Can you try building from source with the patch below applied?

diff --git a/src/node_os.cc b/src/node_os.cc
index d7be909..e31578b 100644
--- a/src/node_os.cc
+++ b/src/node_os.cc
@@ -125,8 +125,13 @@ static void GetOSRelease(const FunctionCallbackInfo<Value>& args) {
 
   // Don't complain that GetVersionEx is deprecated; there is no alternative.
   #pragma warning(suppress : 4996)
-  if (GetVersionExW(&info) == 0)
+  if (GetVersionExW(&info) == 0) {
+    auto isolate = args.GetIsolate();
+    auto exception =
+        WinapiErrnoException(isolate, GetLastError(), "GetVersionEx");
+    isolate->ThrowException(exception);
     return;
+  }
 
   snprintf(release,
            sizeof(release),

Seems to be a duplicate of #7837. Please try with the latest node.js version.

It seems #8645 got backported to 6.x, but the libuv upgrade (#9267 and #9647) wasn't. cc @nodejs/lts

I've reverted the offending commit in 1978911, this should be fixed in the next v6.x LTS release

@seishun

@seishun my node version is 6.10.1 which is latest version of LTS already

Revert "Revert "repl: disable Ctrl+C support..."

I can't tell if this was fixed in 6.10.2 or if it's expected to be fixed in 6.11.2. Can someone confirm the bug on Windows in 6.10.2 or later?

No follow-up and no one complained so I'll go ahead and assume this is fixed. If not, please leave a comment.

Navigation Menu

Repository navigation

Sometimes REPL cannot display the result #12085

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Sometimes REPL cannot display the result #12085

Description

Activity

bnoordhuis commented on Mar 28, 2017

seishun commented on Mar 28, 2017

seishun commented on Mar 28, 2017

MylesBorins commented on Mar 28, 2017

betimer commented on Mar 28, 2017

Trott commented on Jul 30, 2017

bnoordhuis commented on Oct 26, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions