Repository navigation
test the benchmarks at one iteration #12068
Description
Activity
Ah, only for
net. Yeah, some adjustments will need to be made to the benchmarks in general.e.g. some still run iterations even when it is set to
1: https://github.com/nodejs/node/blob/master/benchmark/timers/timers-cancel-pooled.js#L10- added 6 commits that reference this issue
on Apr 9, 2017 - added a commit that references this issue
on Apr 19, 2017 22 remaining items
This is done now. Closing.
Of course we don't want to "actually" run the benchmarks during a test run. However, the benchmark runner already is able to set how many iterations the benchmarks run, and we could probably extend that even more.
As such, I don't see much reason to not run most of the benchmarks during a normal test run, with e.g. only one iteration set.
Or, at the very least perhaps we could have some sort of special CI job that does that, to be run, say, weekly.
cc @nodejs/testing @nodejs/benchmarking