镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

missing #include <unicode/ustring.h> #11753

Closed
Closed
missing #include <unicode/ustring.h>#11753
Assignees
srl295
Labels
i18n-apiIssues and PRs related to Node.js internationalization support.

Description

@srl295
srl295
opened on Mar 8, 2017
  • Subsystem: core/deps

An ICU header was missing from the #includes. This works on current ICU, but fails later when an indirect dependency changes.

diff --git a/deps/v8/src/runtime/runtime-i18n.cc b/deps/v8/src/runtime/runtime-i18n.cc
index 75e0952..c923c17 100644
--- a/deps/v8/src/runtime/runtime-i18n.cc
+++ b/deps/v8/src/runtime/runtime-i18n.cc
@@ -42,6 +42,7 @@
 #include "unicode/unistr.h"
 #include "unicode/unum.h"
 #include "unicode/uversion.h"
+#include "unicode/ustring.h"
 
 
 namespace v8 {
diff --git a/src/node_i18n.cc b/src/node_i18n.cc
index b337456..fab594c 100644
--- a/src/node_i18n.cc
+++ b/src/node_i18n.cc
@@ -43,6 +43,7 @@
 #include <unicode/ulocdata.h>
 #include <unicode/uvernum.h>
 #include <unicode/uversion.h>
+#include <unicode/ustring.h>
 
 #ifdef NODE_HAVE_SMALL_ICU
 /* if this is defined, we have a 'secondary' entry point.

Activity

  1. srl295
    added
    i18n-apiIssues and PRs related to Node.js internationalization support.
    on Mar 8, 2017
  2. srl295
    self-assigned this
    on Mar 8, 2017

  3. srl295 commented on Mar 8, 2017

    @srl295
    srl295
    on Mar 8, 2017
    MemberAuthor

    The second is a v8 patch.

  4. srl295
    closed this as completedin #11754on Mar 9, 2017
  5. italoacasas
    added a commit that references this issue on Mar 13, 2017

    src: add missing #include <unicode/ustring.h>

    032becd
  6. jungx098
    added a commit that references this issue on Mar 21, 2017

    src: add missing #include <unicode/ustring.h>

    fddb23e

  7. srl295 commented on Mar 27, 2017

    @srl295
    srl295
    on Mar 27, 2017
    MemberAuthor

    v8 side: https://codereview.chromium.org/2738453005/ and https://codereview.chromium.org/2738503008/

  8. srl295 commented on Mar 27, 2017

    @srl295
    srl295
    on Mar 27, 2017
    MemberAuthor
    • v8 changes above still don't seem to have landed in node HEAD. Filed CrBug:6173

  9. jungshik commented on Mar 29, 2017

    @jungshik
    jungshik
    on Mar 29, 2017

    https://chromium.googlesource.com/v8/v8/+/5.9.35 is the first v8 release with the v8-side fix. Can Node head roll v8 to that version or later, instead (while rolling ICU to 59) ?

  10. srl295 commented on Mar 29, 2017

    @srl295
    srl295
    on Mar 29, 2017
    MemberAuthor

    @jungshik will investigate that- the back port would allow older nodes to support newer icu though.

  11. srl295
    added a commit that references this issue on Mar 30, 2017

    tools: add missing #include "unicode/putil.h"

    b084907
  12. italoacasas
    added a commit that references this issue on Apr 10, 2017

    tools: add missing #include "unicode/putil.h"

    fdf76d5

  13. MylesBorins commented on Apr 17, 2017

    @MylesBorins
    MylesBorins
    on Apr 17, 2017
    Contributor

    @srl295 should this be backported to v6.x?

  14. MylesBorins
    added
    lts-watch-v6.x
    on Apr 17, 2017

  15. srl295 commented on Apr 18, 2017

    @srl295
    srl295
    on Apr 18, 2017
    MemberAuthor

    @MylesBorins it doesn't hurt… it could backport to v0.12 for that matter… however, without the (trivial) v8 patch, it's not going to work in previous versions.

    So yes, it would probably be a good idea to back port it.

  16. srl295 commented on Apr 18, 2017

    @srl295
    srl295
    on Apr 18, 2017
    MemberAuthor

    re v8 5.9.35: #11827

  17. srl295 commented on May 8, 2017

    @srl295
    srl295
    on May 8, 2017
    MemberAuthor

    For the record: This issue was fixed by a v8 bump in 60d1aac specifically 60d1aac#diff-df47c9a27158d9fcec0511ec405f9172

  18. MylesBorins
    added 2 commits that reference this issue on Aug 14, 2017

    tools: add missing #include "unicode/putil.h"

    cbd2c77

    tools: add missing #include "unicode/putil.h"

    74d5cba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

i18n-apiIssues and PRs related to Node.js internationalization support.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions