Repository navigation
Release proposal: v1.6.0 #1157
Description
Activity
ahhh ya beat me to it, I decided to hold off until tomorrow haha
👍
[7bde3f1] - (SEMVER-MINOR) src: add -r/--require flags for preloading modules (Ali Ijaz Sheikh)
This patch has been reverted for now I thought?
- Revert stream base #1140: Revert stream base Revert stream base #1140
This should probably be a semver-major change if accepted (I don't think it will be, that issue seems to be going another way).
A good reason for semver-minor could be #1156
Another one: #1162
Since 095ae0d is my commit, I'm not sure if I should chime in or not but its just making socket*() return the ip/port used even after the socket is closed. Before that commit, if the socket was closed, socket*() methods would return null.
@fastest963 I suggested semver-minor because it can break code that uses e.g.
socket.remotePort === undefinedas an indicator of whether the socket is connected.@bnoordhuis thanks for the clarification. Makes sense.
will try and get this out tomorrow, then I guess we'll have 1.6.1 to do in a couple of days after that thanks to openssl.
@rvagg Your CI of 317 was deleted and my job had an error as https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/318/console . Is there something wrong on CI?
@shigeki yeah, so it seems :-/
18 remaining items
Release commit is authored. Editing the markdown out is kind of a slog – anyone have a better solution?
Tagged and pushed to v1.x. Starting release process.
Job is here.
OSX build has finished. Tested against hapi on v10.10, works.
Windows 2008 x64 has finished. Tested against hapi on windows 7. Some test failures (looks like it was sniffing for error messages!)
Looks like our ARM friends have hung. Proceeding to promote others, will circle back on ARM builds later.
Done. cc @Fishrock123, we should be good to go.
Website updated: nodejs/iojs.org@8a6bb34
Great job all 🎉
@chrisdickinson the arm builds for 1.6.0 are ready to promote, would you mind bumping those with tools/release.sh
@rvagg sorry, I dropped the ball on the arm builds. OK to run this now?
@chrisdickinson yep, should be, first time we've had overlap like this so I'm keen to see if it works as planned!
Seems to have worked!
We're starting to need a new release but we're in an awkward position of not having a good story around a semver-minor bump and there's a few issues & PRs in flux that would be good to get resolved before a release.
Note in the commit list below, the commit from #881 was reverted so no longer applies, but its resolution may be at hand so it can come back in. This would help with a 1.6.0 justification.
Also for those interested in semver arguments, please head over to #1116 and see what you think about it being semver-minor or semver-patch. It's the only thing in here that's warranting the bump to 1.6. If it wasn't for this addition then I'd have just pushed for a quick 1.5.2 and be done with this batch of commits.
So, I'm proposing a holding pattern for this release for up to 3 days to see if we can get some meat in here. Some issues worth monitoring are:
c638dad567] - benchmark: add output format option [csv] (Brendan Ashworth) #77797d8d4928d] - benchmark: add plot_csv R graphing script (Brendan Ashworth) #77707c066724c] - buffer: align chunks on 8-byte boundary (Fedor Indutny) #11268070b1ff99] - buffer: Don't assign .parent if none exists (Trevor Norris) #1109dd37fb4c48] - build: remove incorrect argument in vcbuild.bat (Jeremiah Senkpiel) #119889bf6c05e9] - build: allow custom PackageMaker path (Julien Gilli) joyent/node#937741c9daa143] - build: fix incorrect set in vcbuild.bat (Bert Belder)8b2363d2fd] - configure: use gcc and g++ as CC and CXX defaults (Ben Noordhuis) #1174d8c4a932c9] - crypto: add deprecated ValiCert CA for cross cert (Shigeki Ohtsu) #113565d0a8eca8] - deps: make node-gyp work with io.js (cjihrig) #9907d0baf1741] - deps: upgrade npm to 2.7.1 (Forrest L Norvell) #11422b63bcd247] - doc: add yosuke-furukawa as collaborator (Yosuke Furukawa) #118369350baaef] - doc: update test section in CONTRIBUTING.md (Ben Noordhuis) #11813c8ae2d934] - doc: add petkaantonov as collaborator (Petka Antonov) #117992c1ad97c0] - doc: add silverwind as collaborator (Roman Reiss) #117614c74d5326] - doc: add jbergstroem as collaborator (Johan Bergström) #117508ec897f82] - doc: fix typo in buffer module documentation (Alex Yursha) #1169e6e616fdcb] - doc: fix '' typos on Windows (Steven Vercruysse) joyent/node#9412a28945b128] - doc: reflect new require('events') behaviour (Alex Yursha) #9757a5b023bac] - doc: fix vm module examples (FangDun Cai) #1147d33a647b4b] - doc: make tools/update-authors.sh cross-platform (Ben Noordhuis) #112160dac07b06] - doc: add Malte-Thorben Bruns to .mailmap (Ben Noordhuis) #111880e14d736e] - doc: move checkServerIdentity option to tls.connect() (skenqbx) #1107684a5878b6] - doc: fix missing periods in url.markdown (Ryuichi Okumura) #1115a6af709489] - fs: use stat.st_size only to read regular files (Santiago Gimeno) #1074b2e00e38dc] - (SEMVER-MINOR) http: add flushHeaders and deprecate flush (Yosuke Furukawa) #11568453fbc879] - https: don't overwrite servername option (skenqbx) #11102b2e48a4b9] - lib: don't error in repl when cwd doesn't exist (Ben Noordhuis) #1194f58e59649d] - lib: remove broken NODE_MODULE_CONTEXTS feature (Ben Noordhuis) #1162480b48244f] - (SEMVER-MINOR) lib: allow server.listen({ port: "1234" }) (Ben Noordhuis) #111668d4bed2fd] - make: remove node_dtrace from cpplint excludes (Julien Gilli) joyent/node#874130666f22ca] - net: use cached peername to resolve remote fields (James Hartig) joyent/node#9366eb995d6822] - path: add type checking for path inputs (cjihrig) #115385a92a37ef] - querystring: optimize parse and stringify (Brian White) #8471514b82355] - (SEMVER-MINOR) src: add -r/--require flags for preloading modules (Ali Ijaz Sheikh) #8812c6f79c08c] - src: don't error at startup when cwd doesn't exist (Ben Noordhuis) #1194fe0f015c51] - src: fix crypto bio integer wraparound on 32 bits (Ben Noordhuis) #11922551c1d2ca] - src: use Number::New() for heapTotal/heapUsed (Ben Noordhuis) #11484f394998ba] - src: don't create js string twice on error (Ben Noordhuis) #1148056ed4b0c9] - src: revert -r/--require flags (Chris Dickinson) #11507bde3f1a8f] - (SEMVER-MINOR) src: add -r/--require flags for preloading modules (Ali Ijaz Sheikh) #881e2c9040995] - src: do not leak handles on debug and exit (Fedor Indutny) #1133f600111d82] - test: cache lazy properties, fix style nits (Rod Vagg) #11963038b8ee6a] - test: double timeout in tls-wrap-timeout.js (Fedor Indutny) #1201c15e81afdd] - test: Introduce knowledge of FreeBSD jails (Johan Bergström) #116753e200acc2] - test: fix test-http-content-length (Jeremiah Senkpiel) #114582f067e60b] - test: fix ext commands to be double quoted (Shigeki Ohtsu) #11225ecdc0314d] - test: add test for reading a large file through a pipe (Santiago Gimeno) #10740782c24993] - test: fix readfile-zero-byte-liar test (Santiago Gimeno) #10744eb8810a27] - tls: re-enable.writev()on TLSWrap (Fedor Indutny) #1155e90ed790c3] - tls: fix leak onDoWrite()errors (Fedor Indutny) #11548431fc53f1] - tls_wrap: proxy handle methods in prototype (Fedor Indutny) #110822793da485] - v8: fix --max_old_space_size=4096 integer overflow (Ben Noordhuis) #11668c4f0df464] - v8: fix build on solaris platforms (Johan Bergström) #1079