Repository navigation
Check cwd before spawning child process #11520
Description
Activity
- addedchild_processIssues and PRs related to the child_process subsystem.Issues and PRs related to the child_process subsystem.feature requestIssues requesting new Node.js features.Issues requesting new Node.js features.libuvIssues and PRs related to the libuv dependency or the uv binding.Issues and PRs related to the libuv dependency or the uv binding.
on Feb 23, 2017 That's going to be difficult because the error needs to bubble up from a long way down. I don't think it can be done without backwards-incompatible changes to libuv, which means it won't happen before libuv v2.0.
That's going to be difficult because the error needs to bubble up from a long way down
This means that checking the cwd beforehand (with
fs.existsfor instance) is not an option?No, that's prone to race conditions (TOCTOU issues.) It's going to work alright 99% of the time and that might be acceptable for an npm module but requirements for node.js core are more stringent.
How about add an option
checkCWD?something like:
.spawn(path, { cwd: "some/cwd", checkCWD: true });
Check-before-use is an anti-pattern. It's not something to codify in the API.
Reacted by Remi Liu and Mila Rodriguez@mrpeu Probably because you use
~in the file path. No shell expansion is done.Reacted by MrPeuCheck-before-use is an anti-pattern.
@bnoordhuis why is that?
- Reacted by Gibson Fahnestock, MrPeu, Mila Rodriguez and Zxilly
Doesn't the current code follow
TOCTOU? (though the window between TOC and TOU is narrow)Given the error is captured right and only issue is with the error message, how about making this explicit in the doc?
Could you do a check after the fact simply for the purpose of giving a better error message? i.e. if you get an ENOENT, check if the cwd exists, if not then give an error message specific to that. In the worst case you provide a wrong error message, but not a wrong program behavior.
Reacted by Johannes Ewald, P. Roebuck, Pony CI and Govind RaiStill happening to me. Is there at least a manual way to work around this? Ubuntu on armv7.
@ctday You can check after the fact whether it is the cwd or the node executable that is ENOENT (use
fs.stat()).Ok, thanks.
There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment.
For more information on how the project manages feature requests, please consult the feature request management document.
- addedstaleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.Issues and PRs marked stale due to inactivity and scheduled for automatic closure.
on Feb 28, 2022 There has been no activity on this feature request and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment.
For more information on how the project manages feature requests, please consult the feature request management document.
- added a commit that references this issue
on Jul 30, 2026
When a cwd is passed to
child_process.spawn()that does not exist, node just reportsENOENT:This error message is very confusing because it reads like
/usr/local/bin/nodedoes not exist. It took me several hours to debug this issue, including serious doubts in my sanity 😁.Do you think it is feasible to check the cwd before spawning the process, or is there a use-case/is it possible to spawn a process with a non-existent cwd? If it's not feasible, would it be an option to include the cwd in the error message to give a slight hint in the right direction?