url: export URLSearchParams alongside URL #10761

Activity

1. jasnell

   added

   whatwg-urlIssues and PRs related to the WHATWG URL implementation.Issues and PRs related to the WHATWG URL implementation.

   on Jan 12, 2017
2. TimothyGu commented on Jan 14, 2017

   

   TimothyGu

   on Jan 14, 2017

   Member

   More actions

   This is done in #10399, though I can split out the specific change if needed.
3. TimothyGu

   added a commit that references this issue on Jan 14, 2017

   url: export URLSearchParams

   ...

   This issue will close once commit e439047 is merged into the 'master' branch.

   e439047
4. TimothyGu commented on Jan 14, 2017

   

   TimothyGu

   on Jan 14, 2017

   Member

   More actions

   Done in #10801.
5. targos

   closed this as completedin 326e967on Jan 22, 2017
6. joyeecheung commented on Jan 22, 2017

   

   joyeecheung

   on Jan 22, 2017

   Member

   More actions

   @targos @TimothyGu This commit doesn't seem to to have the necessary metadata in the commit message?

   326e967
7. targos commented on Jan 22, 2017

   

   targos

   on Jan 22, 2017

   Member

   More actions

   Oh I didn't mean to push this commit. This was a mistake.
   @nodejs/ctc the 10 minutes to force push are long gone but can we still remove it?
8. joyeecheung

   reopened this on Jan 23, 2017
9. joyeecheung commented on Jan 23, 2017

   

   joyeecheung

   on Jan 23, 2017

   Member

   More actions

   Maybe just revert and reland it?
10. targos commented on Jan 23, 2017

    

    targos

    on Jan 23, 2017

    Member

    More actions

    I guess that harm is done anyway (regarding tooling). I added the metadata as a comment in the commit.

    👍React with 👍2Reacted by Anna Henningsen and Gibson Fahnestock
11. targos

    closed this as completedon Jan 23, 2017
12. jasnell commented on Jan 23, 2017

    

    jasnell

    on Jan 23, 2017

    MemberAuthor

    More actions

    @joyeecheung the way we handle it is within the first ten minutes after a commit, and only if no other commits have landed since, a commit can be edited or amended to fix metadata with a force push. That is the only window of time given to correct a commit without requiring a full revert pr that would go through the normal review process.
13. joyeecheung commented on Jan 23, 2017

    

    joyeecheung

    on Jan 23, 2017

    Member

    More actions

    @jasnell What I meant was a revert PR followed by a reland PR though. The release team has been notified via IRC so I think it's OK to leave it as-is.
14. jasnell commented on Jan 23, 2017

    

    jasnell

    on Jan 23, 2017

    MemberAuthor

    More actions

    It's typically not worth the additional clutter that would cause simply to update the metadata :-)
15. italoacasas

    added 4 commits that reference this issue on Jan 25, 2017

    url: export URLSearchParams

    ...

    This issue will close once commit 6e4341d is merged into the 'master' branch.

    6e4341d

    url: export URLSearchParams

    ...

    This issue will close once commit fe8ae42 is merged into the 'master' branch.

    fe8ae42

    url: export URLSearchParams

    ...

    This issue will close once commit 021338d is merged into the 'master' branch.

    021338d

    url: export URLSearchParams

    ...

    This issue will close once commit 967be4c is merged into the 'master' branch.

    967be4c