镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

tls: secureConnect event will not be emitted if TLSSocket is created via constructor instead of tls.connect #10555

Description

@nbdd0121
  • Version: 7.3
  • Platform: Any
  • Subsystem: Any

In current TLS doc, secureConnect is documented as an event of TLSSocket. However, the event will only be emitted if the socket is created via tls.connect. Basically there is no sensible event to listen on for the 'connect' event if the socket is created directly via new tls.TLSSocket.

Activity

  1. added
    tlsIssues and PRs related to the tls subsystem.
    on Dec 31, 2016
  2. added
    docIssues and PRs related to Node.js documentation.
    on Jan 16, 2017
  3. sam-github commented on Jan 16, 2017

    @sam-github
    Contributor

    Confirmed. I will document.

  4. sam-github commented on Jan 19, 2017

    @sam-github
    Contributor

    PTAL at #10846

  5. Trott commented on Jul 16, 2017

    @Trott
    Member

    @sam-github Should this issue remain open?

  6. sam-github commented on Jul 21, 2017

    @sam-github
    Contributor

    Yes, our documentation is incorrect, and parts of the TLS API are unuseable now (at least, not useable with documented methods and events). I tried to fix, but #10846 was rejected.

  7. BridgeAR commented on Apr 22, 2018

    @BridgeAR
    Member

    I guess #10846 would be a good starting point to fix this. It was just closed due to being stalled and did not get rejected.

  8. jasnell commented on Oct 19, 2018

    @jasnell
    Member

    Ping @sam-github ... would you be interested in taking another run at #10846?

  9. Antonius-S commented on May 12, 2021

    @Antonius-S

    I wonder why on Earth this underwater stone exists. IMHO it only increases WTF-per-minute value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to Node.js documentation.tlsIssues and PRs related to the tls subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions