Repository navigation
tools: evaluate removing args exception from no-unused-vars lint rule #10129
Description
Activity
I'd be happy to go through and make the changes to get rid of any unused arguments if we exempt them from the no-unused-vars rule.
Furthermore, why do we even allow unused variables? Isn't that just wasting size and run time resources?I think the only reason we still have these is because a big change like that can make it harder to
git blame, but I'd say code quality trumps that.Closing due to inactivity. Feel free to re-open if that's The Wrong Thing to do.
To avoid issues like #10041, I propose removing the eslint option that exempts unused function arguments from the
no-unused-varsrule. There are currently 426 violations in the codebase, with around 60 of them inlib.If we want to retain certain arguments for clarity, we can just wrap them in comment tags.