You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have updated the compiler to resolve that issue.
Running on nodejs/node-v8, refs/heads/canary
{anonymous}::AdaptorWithExitFrameType(v8::internal::MacroAssembler*, v8::internal::Builtins::ExitFrameType)':
../deps/v8/src/builtins/ppc/builtins-ppc.cc:70:3: error: 'CEntryStub' was not declared in this scope
CEntryStub stub(masm->isolate(), 1, kDontSaveFPRegs, kArgvOnStack,
^~~~~~~~~~
../deps/v8/src/builtins/ppc/builtins-ppc.cc:72:15: error: 'stub' was not declared in this scope
__ Jump(stub.GetCode(), RelocInfo::CODE_TARGET);
^~~~
@jBarz you had mentioned that you had gotten it to compile ok before so I could be wrong about it being related to what @bnoordhuis is working on can you check with @john-yan to see if its something that needs a port on our side or not.
Thinking about it I'm guess I'm most likely wrong and its more likely that we may not be up to date. In any case @jBarz and @john-yan can you figure that out.
@targos thanks for checking. It is still GCC 6.3, our previous install (bit of a long story) ended up having missed some files due to absolute symlinks that did not match where it is installed on the community machines. We've fixed that.
Activity
mhdawson commentedon May 1, 2018
@john-yan @jBarz
jBarz commentedon May 1, 2018
looking into it
jBarz commentedon May 2, 2018
fyi, I am able to build the
canary-basebranch on my local aix machine using gcc 6.3.0.mhdawson commentedon May 10, 2018
We have updated the compiler to resolve that issue.
Running on nodejs/node-v8, refs/heads/canary
but that looks related to #58 @bnoordhuis as opposed to the error reported here. @bnoordhuis
@jBarz you had mentioned that you had gotten it to compile ok before so I could be wrong about it being related to what @bnoordhuis is working on can you check with @john-yan to see if its something that needs a port on our side or not.
mhdawson commentedon May 10, 2018
Thinking about it I'm guess I'm most likely wrong and its more likely that we may not be up to date. In any case @jBarz and @john-yan can you figure that out.
john-yan commentedon May 10, 2018
@mhdawson Can you please update v8 source to latest again? There is a breaking change came in a few days ago and fixed by this port: https://chromium-review.googlesource.com/c/v8/v8/+/1050732
targos commentedon May 11, 2018
Today's canary build looks good on AIX, thanks!
https://ci.nodejs.org/job/node-test-commit-node-v8/32/
Do we need to update the requirements in https://github.com/nodejs/node/blob/master/BUILDING.md#aix or GCC 6.3 is good enough?
mhdawson commentedon May 11, 2018
@targos thanks for checking. It is still GCC 6.3, our previous install (bit of a long story) ended up having missed some files due to absolute symlinks that did not match where it is installed on the community machines. We've fixed that.
targos commentedon May 11, 2018
Okay, this can be closed then!