You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Last builds lack Windows installers and binaries #19
@refack. Thanks. If you have a working patch, feel free to push a commit on top of canary-base (in nodejs/node, not this repo). The daily job will pick it up tomorrow.
@hashseed I understand that maintaining VS2015 support is a burden for V8. However, for building native modules, node users must also have VS installed. Asking all node users with VS2015 to update is something that would be good to avoid, some of them might not even be able to. It would be great if V8 could test building node with VS2017 and then testing addons with VS2015, to avoid issues like #4. If this can be done, is there anything I can do to help?
Asking all node users with VS2015 to update is something that would be good to avoid, some of them might not even be able to.
On the other hand, assuming VS2015 is binary incompatible with VS2017, we are currently forcing node users with VS2017 to install VS2015 alongside it, which is arguably worse.
There is the issue of building node core from source, not just addons. Dropping official support for VS2015 is one thing, actually breaking support it is semver-major.
Activity
targos commentedon Oct 20, 2017
That's because the build is broken on Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/12687/
refack commentedon Oct 20, 2017
Also checking out
targos commentedon Oct 26, 2017
Still failing: https://ci.nodejs.org/job/node-compile-windows/12882/
vsemozhetbyt commentedon Oct 31, 2017
Still lack.
cc @nodejs/platform-windows?
seishun commentedon Oct 31, 2017
CI looks fine, so it's up to @nodejs/build
targos commentedon Oct 31, 2017
CI does not look fine. Here is the last run: https://ci.nodejs.org/job/node-test-commit-windows-fanned/12997/
seishun commentedon Oct 31, 2017
Ah, the dreaded parallel/test-async-wrap-uncaughtexception. See nodejs/node#16210
targos commentedon Oct 31, 2017
Not really. It doesn't even compile.
refack commentedon Oct 31, 2017
It's that json bug. I have a patch for that. I wanted to upstream. I'll float here.
targos commentedon Oct 31, 2017
@refack. Thanks. If you have a working patch, feel free to push a commit on top of
canary-base(in nodejs/node, not this repo). The daily job will pick it up tomorrow.seishun commentedon Oct 31, 2017
I see here that the last few builds were successful though: https://ci.nodejs.org/job/node-compile-windows/
targos commentedon Oct 31, 2017
We only have one canary build per day (unless it's manually triggered). They share the same platform jobs with regular CI.
bzoz commentedon Oct 31, 2017
nodejs/node@dfcaf28 fixed Windows compilation
seishun commentedon Nov 1, 2017
@bzoz we're talking about v8-canary, not master. Took me a while to realize it too.
vsemozhetbyt commentedon Nov 7, 2017
Ping)
12 remaining items
joaocgreis commentedon Nov 9, 2017
Do we need the version of V8 that is failing to land in node v9.x?
Adding a new release machine with VS2017 (ref nodejs/node#13052 and nodejs/node#16868) will fix this.
@hashseed I understand that maintaining VS2015 support is a burden for V8. However, for building native modules, node users must also have VS installed. Asking all node users with VS2015 to update is something that would be good to avoid, some of them might not even be able to. It would be great if V8 could test building node with VS2017 and then testing addons with VS2015, to avoid issues like #4. If this can be done, is there anything I can do to help?
seishun commentedon Nov 9, 2017
On the other hand, assuming VS2015 is binary incompatible with VS2017, we are currently forcing node users with VS2017 to install VS2015 alongside it, which is arguably worse.
joaocgreis commentedon Nov 9, 2017
Are we? How? node-gyp should be able to use either and both are supported by us.
refack commentedon Nov 9, 2017
Fix landed in V8 master, now being backported - https://bugs.chromium.org/p/v8/issues/detail?id=7061
seishun commentedon Nov 9, 2017
Well that confirms that VS2015 is binary compatible with VS2017. If they weren't, addons built with VS2017 wouldn't work with node built with VS2015.
refack commentedon Nov 9, 2017
Ignore my last comment. It's about the build issue not the extended constexpr.
refack commentedon Nov 9, 2017
There is the issue of building node core from source, not just addons. Dropping official support for VS2015 is one thing, actually breaking support it is semver-major.
Let's keep that discussion in nodejs/node#16868.
targos commentedon Nov 18, 2017
Do we have a release machine with VS2017?
[-]Last two builds lack Windows installers and binaries[/-][+]Last builds lack Windows installers and binaries[/+]refack commentedon Nov 18, 2017
@joaocgreis is working on some bugs in vcbuild.bat -
nodejs/node#17101
vsemozhetbyt commentedon Nov 30, 2017
Is there any progress on this? We still have no Windows binaries.
seishun commentedon Nov 30, 2017
AFAIK @joaocgreis is working on a VS2017 release machine.
joaocgreis commentedon Nov 30, 2017
Release machines ready and working. First node-v8 test run: https://nodejs.org/download/test/v10.0.0-test201711308c5d0f1f35/ . Today's nightlies should already be build by the new machines, if everything goes well this should be fixed.
vsemozhetbyt commentedon Dec 1, 2017
This is fixed! Thank you all!
https://nodejs.org/download/v8-canary/v10.0.0-v8-canary201711307338c21936/