This repository was archived by the owner on Jun 18, 2021. It is now read-only.
Repository navigation
This repository was archived by the owner on Jun 18, 2021. It is now read-only.
nit? s/nodereport/node-report #35
Description
I think node-report is closer to our typical conventions than nodereport, plus it fits nicely with node-inspect, node-heapdump, node-profiler etc. Do you think it would be worth changing the name of the repo, module, etc.? Certainly the sooner the better if we're going to do that.
Personally I think we should change it, I can even put it on my own backlog if others agree.
Activity
gibfahn commentedon Jan 4, 2017
I think if we're going to change it the earlier the better.
richardlau commentedon Jan 4, 2017
https://www.npmjs.com/package/node-report Is already taken.
williamkapke commentedon Jan 4, 2017
/cc @chirag04
chirag04 commentedon Jan 4, 2017
i'm not using
node-reportand seems like nobody else is. i don't even remember if node-report is actually doing anything meaningful.happy to transfer.
rnchamberlain commentedon Jan 5, 2017
Thanks @chirag04, node-report would be a better name for this project and module
mhdawson commentedon Jan 5, 2017
Provided we can get the name in the appropriate places +1 from me.
chirag04 commentedon Jan 5, 2017
I added @rnchamberlain as the owner. Feel to claim it. let me know if i can do anything else to help here.
richardlau commentedon Jan 9, 2017
We're due a semver-major bump for #25 -- Would seem the ideal time to do the rename (if it's not going to take long).
rnchamberlain commentedon Jan 10, 2017
@richardlau agree re #25, but I also have a fix coming up for #6 which changes nodereport behaviour and I'd like to release that at the same time.
Currently nodereport is at v1.0.7 and node-report is v0.1.0. Would we move node-report to v1.0.0?
gibfahn commentedon Jan 10, 2017
@rnchamberlain It's probably worth creating a github milestone for the next major release.
+1 to
v2.0.0richardlau commentedon Jan 12, 2017
#37 handles renaming in the source code.
Who can rename this repository?
rnchamberlain commentedon Jan 13, 2017
According to https://github.com/proxy/help.github.com/articles/renaming-a-repository/ someone with the powers will have a gear wheel/settings tab showing on the main repo page https://github.com/nodejs/nodereport. I'm not seeing that myself.
williamkapke commentedon Jan 14, 2017
Looking at the list of Org
ownersthat have also been somewhat involved in this group... let's ping @mhdawson and maybe @Fishrock123rnchamberlain commentedon Jan 20, 2017
Suggested steps required, in sequence:
Rename this repo to github.com/nodejs/node-report - done
Update the module code, readme, tests and demos to use the new "node-report" name where appropriate, see Rename nodereport module to node-report #52 - done
Version as v2.0.0 and release on https://www.npmjs.com/package/node-report - done
Update the readme on https://www.npmjs.com/package/nodereport to say it's obsolete, and reference the new one. For npm to publish the updated readme we'll need a package.json increment to v1.0.8 on there. - done
Run
npm deprecateon the old package so that users get a warning message when they install it - donePrior to this change, the report files produced were named NodeReport.<date>.<time>.<pid>.<seq>.txt. From version 2.0.0 report filenames are node-report.<date>.<time>.<pid>.<seq>.txt
rnchamberlain commentedon Feb 9, 2017
node-report v2.0.0 now published on https://www.npmjs.com/package/node-report
for changes see https://github.com/nodejs/node-report/blob/master/CHANGES.md
Update README.md to reflect node-report rename
Update README.md to reflect node-report rename (#209)
rnchamberlain commentedon Feb 14, 2017
All done now I think, new git repo is https://github.com/nodejs/node-report, new package is https://www.npmjs.com/package/node-report.
Added message in old package README and npm deprecate warning on nodereport.