still does not detect some non-author committers #150

Activity

1. priyank-p

   added

   bug

   on Jan 18, 2018
2. joyeecheung commented on Jan 18, 2018

   

   joyeecheung

   on Jan 18, 2018

   MemberAuthor

   More actions

   It is kind of weird, the committer and the author actually use the same email, and authoredByCommitter is true here, still GitHub UI does not recognize that...
3. priyank-p commented on Jan 18, 2018

   

   priyank-p

   on Jan 18, 2018

   Contributor

   More actions

   Ah, it might be because the remove the email in the settings.
4. priyank-p

   added

   investigate

   on Jan 18, 2018
5. priyank-p commented on Jan 19, 2018

   

   priyank-p

   on Jan 19, 2018

   Last edited by priyank-p

   Contributor

   More actions

   @joyeecheung the reason i think it failes is because of this here

   node-core-utils/lib/pr_checker.js

   Lines 282 to 286 in e76076d

   	// They have turned on the private email feature, can't really check
   	// anything, GitHub should know how to link that, see nodejs/node#15489
   	if (!pr.author.email) {
   	return false;
   	}

   I don't think email field exists on author. Can you tell me exactly what the purpose was here?

   (I do think they have a GitHub email provied by github for this purposes of making email private)
6. joyeecheung commented on Jan 19, 2018

   

   joyeecheung

   on Jan 19, 2018

   MemberAuthor

   More actions

   @cPhost That is assigned here

   node-core-utils/lib/pr_data.js

   Lines 84 to 86 in e76076d

   	const userData = await request.gql(USER_QUERY, { login: pr.author.login });
   	const user = userData.user;
   	Object.assign(this.pr.author, user);
7. priyank-p commented on Jan 19, 2018

   

   priyank-p

   on Jan 19, 2018

   Last edited by priyank-p

   Contributor

   More actions

   That seems correct. And also you can do this to save you some from doing more work.

   author {
     ... on User {
        email,
        name
     }
   }
8. priyank-p

   removed

   investigate

   on Feb 22, 2018
9. priyank-p

   added 2 commits that reference this issue on Feb 22, 2018

   pr_checker: Log a error is pr author has incorrect git config.

   ...

   fa53701

   pr_checker: Log a error is pr author has incorrect git config.

   ...

   348500b
10. joyeecheung

    closed this as completedin b94a608on Feb 23, 2018
11. johnfrench3

    added a commit that references this issue on Nov 2, 2022

    pr_checker: Log a error is pr author has incorrect git config.

    ...

    202350d
12. renawolford6

    added a commit that references this issue on Nov 10, 2022

    pr_checker: Log a error is pr author has incorrect git config.

    ...

    de9760b
13. Developerarif2

    added a commit that references this issue on Jan 27, 2023

    pr_checker: Log a error is pr author has incorrect git config.

    ...

    36a2674
14. gerkai

    added a commit that references this issue on Jan 27, 2023

    pr_checker: Log a error is pr author has incorrect git config.

    ...

    cb48da7
15. patrickm68

    added a commit that references this issue on Sep 14, 2023

    pr_checker: Log a error is pr author has incorrect git config.

    ...

    a8e4a96