镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Detect double Refs and Fixes entries. #133

Description

@BridgeAR

Right now if the tool is used as it the commit message that is generated duplicates Refs and Fixes entries by amending those blindly. We might come up with a way to remove those - and verify that they are identical with the ones being amended (and if not, it should result in an error).

Activity

  1. joyeecheung commented on Jan 4, 2018

    @joyeecheung
    Member

    BTW https://github.com/nodejs/node-core-utils/pull/106/files#diff-806602ca40b9756be13878981c68b536R109 does handle this in case there are already urls present in the commit message without metadata.

  2. joyeecheung commented on Jan 17, 2018

    @joyeecheung
    Member

    It's fixed by the new git-node command, although it still does not fix the following case:

    Fixes: #XXXX   # put by the author
    
    Something something...
    
    Fixes: https://github.com/nodejs/node/issue/XXXX # generated by us
    
  3. BridgeAR commented on Jan 17, 2018

    @BridgeAR
    MemberAuthor

    @joyeecheung that was the case that I meant ^^.

  4. github-actions commented on Aug 18, 2020

    @github-actions
    Contributor

    This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

  5. codebytere commented on Aug 18, 2020

    @codebytere
    Member

    Will be closed by #478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions