镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Refactor some cmd.js logic out into its own file for easier tests #71

Description

@lholmquist

While working on issue #69 I started to come across places where it was a little difficult to test if just a particular flag was called. I think it might help if some of the logic that is in cmd.js is broken out into its own file, so it would be easier to test if a particular flag was specified, and not necessarily test what that flag actually does. That could be done in its own separate test, where it would be easier to mock certain functions.

@richardlau @Trott thoughts?

I can send a PR so we can talk about it also

Activity

  1. richardlau commented on Jul 18, 2019

    @richardlau
    Member

    I can send a PR so we can talk about it also

    Yeah, send a PR -- It'll be much easier to discuss/reason. I have no objections to the idea in principle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions