镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

Invalid Commit Message #117

Open
Open
Invalid Commit Message#117

Description

@H4ad
H4ad
opened on Oct 4, 2023

This PR was merged with a non-imperative verb starting the commit message: benchmark: added new benchmarks for blob.

From what the docs says, it should be a invalid message.

The CI did raised an error about the length (that I fix) but didn't raise an error about this verb and it was merged.

Activity

  1. tniessen commented on Oct 5, 2023

    @tniessen
    tniessen
    on Oct 5, 2023
    Member

    It is extremely difficult to automatically and reliably determine whether a commit message follows our commit message guidelines exactly. In the end, it is the collaborators' responsibility to only merge commits that follow the guidelines.

  2. tniessen
    transferred this issue fromnodejs/node-core-utilson Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions