镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

ansible: update RHEL 8 cross compiler container - #3274

Merged
richardlau merged 1 commit into
nodejs:mainfrom
richardlau:gcc-10
Apr 3, 2023
Merged

richardlau merged 1 commit into
nodejs:mainfrom
richardlau:gcc-10

Conversation

@richardlau

Copy link
Copy Markdown
Member

Update RHEL 8 container used for cross compiling for armv7.
Add logic to select gcc 10 toolchain for Node.js 20 onwards.
Install gcc-toolset-10 host compiler.

Refs: rvagg/rpi-newer-crosstools#2
Refs: https://github.com/orgs/nodejs/discussions/45892
Refs: nodejs/node#47067

@richardlau

richardlau commented Mar 31, 2023 •

Copy link
Copy Markdown
Member Author

The containers have been updated. The iojs+release and node-cross-compile jobs won't use gcc 10 until they are updated to add the cross-compiler-rhel8-armv7-gcc-10-glibc-2.28 label and the VersionSelectorScript.groovy changes merged.

I copied some of the arm-fanned job so I could pick up the version selector change.
Test build with the copied job: https://ci.nodejs.org/job/richardlau-node-test-commit-arm-fanned/4/

@richardlau

richardlau commented Mar 31, 2023 •

Copy link
Copy Markdown
Member Author

I copied some of the arm-fanned job so I could pick up the version selector change. Test build with the copied job: https://ci.nodejs.org/job/richardlau-node-test-commit-arm-fanned/4/

Tests failed on Debian 10 (expected, see notes in rvagg/rpi-newer-crosstools#2).
Tests passed on Ubuntu 20.04 🎉. I've copied the node-test-binary-armv7l job and modified it to use the VersionSelectorScript.groovy from this PR (which should cause debian10 to be skipped for Node.js 20).

New test CI: https://ci.nodejs.org/job/richardlau-node-test-commit-arm-fanned/8/

@MoLow MoLow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Update RHEL 8 container used for cross compiling for armv7.
Add logic to select gcc 10 toolchain for Node.js 20 onwards.
Install gcc-toolset-10 host compiler.

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau
richardlau merged commit d20d4a0 into nodejs:main Apr 3, 2023
targos pushed a commit to targos/nodejs-build that referenced this pull request Apr 7, 2023
Update RHEL 8 container used for cross compiling for armv7.
Add logic to select gcc 10 toolchain for Node.js 20 onwards.
Install gcc-toolset-10 host compiler.

Refs: rvagg/rpi-newer-crosstools#2
Refs: https://github.com/orgs/nodejs/discussions/45892
Refs: nodejs/node#47067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants