镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

Update tap2junit from 0.1.4 to 0.1.5 #2092

Closed

Description

@Trott

tap2junit 0.1.5 fixes bugs and introduces Python 3 compatibility. Can we please update?

Refs: nodejs/node#30955 (comment)
Maybe Refs: #1847
Maybe Refs: #1756
Maybe Refs: #1830

Activity

  1. Trott commented on Dec 17, 2019

    @Trott
    MemberAuthor
  2. sam-github commented on Dec 17, 2019

    @sam-github
    Contributor

    Work items (volunteers welcome, a number of the items below do not require build-wg membership):

    • Find out how tap2junit is installed: ... (ansible on most hosts)
    • Figure out if it is installed at a specific version: ... (probably its just latest at time of ansible run, but there might be a py3 and a py2 install, or possibly changes will be needed to install with both pip and pip3)
    • Modify ansible files: ... (if necessary, maybe they just need re-running)
    • List hosts that require update: ... (perhaps all test-* hosts, but we never bulk update every single host simultaneously, carnage is too likely)
    • Re-ansible the hosts: ... (some hosts have been ansibled more recently than others, so this can be a bit of a nail biter, the hosts have to be checked after to ensure they still function, and sometimes the ansbile scripts don't run anymore, and troubleshooting ensues)
  3. richardlau commented on Dec 17, 2019

    @richardlau
    Member

    Work items (volunteers welcome, a number of the items below do not require build-wg membership):

    * [ ]  Find out how tap2junit is installed: ... (ansible on most hosts)
    
    * [ ]  Figure out if it is installed at a specific version: ... (probably its just latest at time of ansible run, but there might be a py3 and a py2 install, or possibly changes will be needed to install with both pip and pip3)
    
    * [ ]  Modify ansible files: ... (if necessary, maybe they just need re-running)
    

    For ansible there are several files in https://github.com/nodejs/build/tree/master/ansible/roles/jenkins-worker/tasks/partials/tap2junit

    None of the ansible files appear to specify a version of tap2junit to install.

  4. Trott commented on Feb 8, 2020

    @Trott
    MemberAuthor

    I updated it manually, so I'm inclined to close this. Re-open if you think it should remain open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions