镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

node-test-known-issues, is this job used? can it be deleted? #1874

Closed

Description

@sam-github

quoting @richardlau

I do wonder if that job is still in-use. known_issues tests are run by default in the CI now for Node.js 10 (since 10.9.0, nodejs/node#21910) and above. It doesn't look like that job is chained to any of the regular CI jobs (also indicated by the low build job numbers) and if someone needs to do one-off known_issues test runs they can always use https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/.

In agreement with @rvagg 's points about the CI being too ambitious to be tractable, I'd like to delete the job if its unused -- or prefix the job name with archived- to indicate it isn't used or maintained, or whatever the convention here is to clean up unused jobs.

Activity

  1. sam-github commented on Jul 24, 2019

    @sam-github
    ContributorAuthor

    @Trott in particular, do you have an opinion?

  2. richardlau commented on Jul 24, 2019

    @richardlau
    Member

    (Link to the job being discussed: https://ci.nodejs.org/job/node-test-known-issues/)

  3. Trott commented on Jul 24, 2019

    @Trott
    Member

    I have not used that job in a long time, if ever. I'm totally OK with it going away.

  4. sam-github commented on Jul 25, 2019

    @sam-github
    ContributorAuthor

    I renamed it with an archive- prefix, and changed the description to

    run make/vcbuild test-known-issues -- to be deleted, see #1874

    I'm nervous to outright delete it, do we have ways of bringing them back if some infrequent user of the job panics?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions