This repository was archived by the owner on Nov 28, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Nov 28, 2020. It is now read-only.
Benchmarking for Node Verison 8 -broken by npm upgrade #111
Description
Seems like npm 5 beta in version 8 has broken the benchmark job for version 8.
Most likely because we depend on the location of the .js file as opposed to doing a full install. Need to investigate and fix up path when running with 5.
Activity
mhdawson commentedon May 29, 2017
Issue seems to be that
.../node/deps/npm/cli.jsdoes not exist in master/v8.x but did exist in earlier node versions. It was simply a wrapper that did:mhdawson commentedon May 29, 2017
Looks like instructions in Makefile changes from:
to
in: nodejs/node#12936
So looks like it is on purpose.
mhdawson commentedon May 29, 2017
Testing swapping one command for the other: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-footprint-master/600/console
mhdawson commentedon May 29, 2017
Looks good in the master job, just applying to the 8.x job now.
mhdawson commentedon May 29, 2017
Ok, all green again, closing.