You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
per nodejs/node#39672, it seems the next steps would be to move the bnb/devenv repository into the Node.js org and to PR the .devcontainer dir to nodejs/node. I'd recommend moving it to nodejs/devcontainer.
One thing to note, we'd need to grab a Docker Hub token to publish it to the Node.js Docker Hub account to publish the image. I presume we'll want to publish it to nodejs/devcontainer to match the repo. We will need to choose some kind of name, which will need to be reflected in code here.
Worth noting that this will consume some portion of our Actions minutes. In its first run, it took about an hour and a half to build and publish on the default 2 core runner. I've presently set it up to run nightly, though the cron can be changed through normal means in GitHub. I've talked a bit with the Actions team and it seems that we'd potentially be able to get dedicated runners for this workload - I'll follow up with them once we've moved the repo into the org ❤️
Happy to do this but want to get the appropriate approvals, of course :)
Based on discussion in the TSC meeting today and no objections in the issue believe we can move forward. @bnb if you make me an owner of the repo I can move it over.
Activity
bnb commentedon Nov 15, 2021
cc @nodejs/tsc
also @nodejs/docker potentially worth looking at this. I believe @Trott suggested that y'all might be a good set of stewards if you're okay with that.
Trott commentedon Nov 16, 2021
@bnb Feel free to put a
tsc-agendalabel on this if there's no attention/conversation going on.mhdawson commentedon Nov 16, 2021
+1 from me
jasnell commentedon Dec 2, 2021
SGTM
mhdawson commentedon Dec 2, 2021
Based on discussion in the TSC meeting today and no objections in the issue believe we can move forward. @bnb if you make me an owner of the repo I can move it over.
mhdawson commentedon Dec 16, 2021
@bnb I think we can close this right?
bnb commentedon Dec 16, 2021
Yep!