Repository navigation
create a issue-triage team #552
Description
Activity
+1 👍
I think
issue-triageshould be given "triage" access for the node and help repos, and the usual "write" access to the moderation repo.Reacted by Gireesh Punathil and Michaël Zassothanks @Trott , inline edited the comment with that info
cc @nodejs/tsc @nodejs/community-committee
One question. Will the triage team be able to kick of CI or land commits via labels?
I think there are two questions here
- What are the default permissions
- What behavior do we see as desirable
I don't have super strong opinions just yet, aside from assuring that we are intentional
+1
@MylesBorins - thanks, I don't know the answer to that. Of course the github documentation does not cover that. Looks like the build team, who made the scripts for the CI and LAND workflows would know.
/cc @nodejs/build @nodejs/automation
regarding desired levels: I am fine with permissions for those 2 actions to be granted to triagers, with a reasoning of more permissive than inhibitive, leading to more empowerment
but open to discussions.
Triagers will be able to start CI and land PRs using the commit queue.
Reacted by Gireesh Punathilso that means now the only outstanding question is: are we good to grant these permissions (default github permissions plus CI and land permissions) to triagers?
Looks like you could potentially have a github action to guard those labels by doing some inspection on the sender https://github.com/proxy/docs.github.com/en/developers/webhooks-and-events/webhook-events-and-payloads#label
Still possible for the cron job to pick up the label before that action removes it, but that might not really be a concern you haveReacted by Gireesh PunathilFWIW this is an issue that was raised before landing the commit queue, and the consensus back then was that it's not an issue: nodejs/TSC#907 (comment)
I guess the only question I have is: do we have a clear process for folks to become triagers (like we have for collaborators)? Groking our policy I couldn't find it.
the process is outlined here: https://github.com/nodejs/node/blob/master/doc/guides/contributing/issues.md#triaging-a-bug-report
the key is:
Anyone with a reasonable understanding of Node.js programming and the project's GitHub organization plus a few contributions to the project (commenting on issues or PRs) can apply for and become a triager. Open a PR on the README.md of this project with: i) a request to be added as a triager, ii) the motivation for becoming a triager, and iii) agreement on reading, understanding, and adhering to the project's Code Of Conduct.Reacted by mary marchini and Manash athparia@mmarchini - are you familiar with the process of creating teams, and if so can you make this? (I haven't tried before, don't want to make mistakes.) thanks!
nvm, I attempted one here https://github.com/orgs/nodejs/teams/issue-triage
pls have a look and let me know , especially the
repositoriesattribute.Reacted by Myles Borinsgeneral permissions look good. Do we want this to be a subteam?
@MylesBorins - thanks.
Do we want this to be a subteam?
tbh, no idea. tradeoffs of being / not being a suteam?
@MylesBorins a subteam of which team? It can't be a subteam of collaborators since triagers don't necessarily have commit access.
purpose met -
subteam created, closing
this issue is to:
issue-traigeteam to contain the triage team members (ref: https://github.com/nodejs/node/blob/master/GOVERNANCE.md#triagers and doc: add PoojaDurgad as a triager node#35153 (comment) ) with "triage" access for the node and help repos, and the usual "write" access to the moderation repoEDIT: added the traige access info.