镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

added os-name package - #2

Closed
stevenvachon wants to merge 1 commit into
node-modules:masterfrom
stevenvachon:master
Closed

stevenvachon wants to merge 1 commit into
node-modules:masterfrom
stevenvachon:master

Conversation

@stevenvachon

Copy link
Copy Markdown
Contributor

Closes #1.

Comment thread index.js

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using process.release nodejs/node#493 to support io.js also?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that's pretty new. They're not even sure yet where to put it and I don't see any examples of what its value would look like either. However, yes, supporting this would be a great idea when it's available.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That new process.release Object should no longer be necessary now that io.js and Node.js have merged: http://www.infoq.com/news/2015/05/nodejs-iojs

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that new stuff was added to io.js v3.0.0, but what good is it to us when io.js is officially Node.js now?

@fengmk2

fengmk2 commented Aug 6, 2015

Copy link
Copy Markdown
Member

+1

@fengmk2

fengmk2 commented Aug 6, 2015

Copy link
Copy Markdown
Member

landed 66c8d4b

@fengmk2 fengmk2 closed this Aug 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

os name

2 participants