镜像站点 · 本页由第三方 GitHub 只读镜像提供，非 GitHub 官方站点，不接受任何登录或凭据输入。前往 github.com
Skip to content

fix: make sure etag is a string - #2880

Merged
skjnldsv merged 1 commit into
masterfrom
skjnldsv-patch-1
Jun 20, 2025
Merged

fix: make sure etag is a string#2880
skjnldsv merged 1 commit into
masterfrom
skjnldsv-patch-1

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Jun 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@skjnldsv
skjnldsv requested review from a team, artonge, hamza221, nfebe and susnux and removed request for a team June 19, 2025 08:39
@skjnldsv

skjnldsv commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

/compile amend

@skjnldsv

skjnldsv commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

/backport to stable30

@backportbot backportbot Bot added the backport-request Pending backport by the backport-bot label Jun 19, 2025
@skjnldsv

skjnldsv commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

/backport to stable31

@skjnldsv skjnldsv mentioned this pull request Jun 19, 2025
Closed
6 of 8 tasks
@skjnldsv

skjnldsv commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

/compile

@skjnldsv

skjnldsv commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

Weird, the build looks outdated

artonge
artonge approved these changes Jun 20, 2025
View reviewed changes
Comment thread src/utils/previewUtils.ts Resolved
artonge
artonge reviewed Jun 20, 2025
View reviewed changes
Comment thread src/utils/previewUtils.ts Resolved
@skjnldsv

skjnldsv commented Jun 20, 2025

Copy link
Copy Markdown
Member Author

/compile amend

@skjnldsv @nextcloud-command
fix: make sure etag is a string
e23030a 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv

skjnldsv commented Jun 20, 2025

Copy link
Copy Markdown
Member Author

Unrelated, there's an issue from server

  1) See shared folder with link share
       Opens the shared image in the viewer:
     TypeError: The following error originated from your application code, not from Cypress.

  > self.crypto.randomUUID is not a function

@skjnldsv
skjnldsv merged commit c01c64e into master Jun 20, 2025
@skjnldsv
skjnldsv deleted the skjnldsv-patch-1 branch June 20, 2025 09:51
@backportbot

This comment was marked as resolved.

Sign in to view
@backportbot

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews and removed backport-request Pending backport by the backport-bot labels Jun 21, 2025
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
susnux pushed a commit that referenced this pull request May 16, 2026
@skjnldsv
Merge pull request #2880 from nextcloud/skjnldsv-patch-1
f8af899 
fix: make sure etag is a string
susnux pushed a commit that referenced this pull request May 16, 2026
@skjnldsv
Merge pull request #2880 from nextcloud/skjnldsv-patch-1
c9dc60a 
fix: make sure etag is a string
susnux pushed a commit that referenced this pull request May 16, 2026
@skjnldsv
Merge pull request #2880 from nextcloud/skjnldsv-patch-1
27f8a4c 
fix: make sure etag is a string
susnux pushed a commit that referenced this pull request May 16, 2026
@skjnldsv
Merge pull request #2880 from nextcloud/skjnldsv-patch-1
2f95743 
fix: make sure etag is a string
susnux pushed a commit that referenced this pull request May 16, 2026
@skjnldsv
Merge pull request #2880 from nextcloud/skjnldsv-patch-1
0abc021 
fix: make sure etag is a string
susnux pushed a commit that referenced this pull request May 16, 2026
@skjnldsv
Merge pull request #2880 from nextcloud/skjnldsv-patch-1
d9e8bde 
fix: make sure etag is a string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes
@artonge artonge artonge approved these changes
@hamza221 hamza221 hamza221 approved these changes
@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: (Some) images are not shown when large view is requested

4 participants

@skjnldsv @susnux @artonge @hamza221