镜像站点 · 本页由第三方 GitHub 只读镜像提供,非 GitHub 官方站点,不接受任何登录或凭据输入。前往 github.com
Skip to content

[a11y] add aria-keyshortcuts - #2762

Merged
vinicius73 merged 7 commits into
masterfrom
2735-bitva11y-currently-keyboard-accessible-using-keyboard-shortcuts-common-in-text-editors-however-there-is-a-wai-aria-best-practice
Aug 1, 2022
Merged

vinicius73 merged 7 commits into
masterfrom
2735-bitva11y-currently-keyboard-accessible-using-keyboard-shortcuts-common-in-text-editors-however-there-is-a-wai-aria-best-practice

Conversation

@vinicius73

@vinicius73 vinicius73 commented Jul 29, 2022 •

Copy link
Copy Markdown
Member

Summary

  • add missing aria-keyshortcuts
  • fix some shortcuts
    • strikethrough
    • ordered-list
    • blockquote
  • add missing shortcuts
    • code-block
  • improve mac compatibility
    • use command instead of control in Apple devices
  • add shortcuts tests

@juliusknorr

Copy link
Copy Markdown
Member

Also fixes #2445

@juliusknorr
juliusknorr force-pushed the 2735-bitva11y-currently-keyboard-accessible-using-keyboard-shortcuts-common-in-text-editors-however-there-is-a-wai-aria-best-practice branch from a721c69 to 02330d7 Compare July 30, 2022 08:31
Comment thread src/components/Menu/keys.js Resolved
Comment thread src/components/Menu/keys.js Resolved
Comment thread src/components/Menu/keys.js Resolved
@vinicius73

Copy link
Copy Markdown
Member Author

/rebase

Vinicius Reis and others added 6 commits August 1, 2022 11:56
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
- strikethrough
- blockquote
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Co-authored-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Vinicius Reis <luiz.vinicius73@gmail.com>
@nextcloud-command
nextcloud-command force-pushed the 2735-bitva11y-currently-keyboard-accessible-using-keyboard-shortcuts-common-in-text-editors-however-there-is-a-wai-aria-best-practice branch from eaf3d57 to 6d8b6ac Compare August 1, 2022 11:56
@vinicius73

Copy link
Copy Markdown
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@vinicius73
vinicius73 merged commit a84d082 into master Aug 1, 2022
@delete-merged-branch
delete-merged-branch Bot deleted the 2735-bitva11y-currently-keyboard-accessible-using-keyboard-shortcuts-common-in-text-editors-however-there-is-a-wai-aria-best-practice branch August 1, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review accessibility enhancement New feature or request tests If you write them we ♥ you

Projects

None yet

5 participants