Repository navigation
Refactor: Split Editor Wrapper into multiple components - #2687
Merged
Merged
Conversation
max-nextcloud
force-pushed
the
refactor/split-editor-wrapper
branch
2 times, most recently
from
July 8, 2022 21:50
41814bf to
41661ec
Compare
max-nextcloud
marked this pull request as ready for review
July 8, 2022 21:59
Collaborator
Author
|
This is just some preparation - but i think it's helpful in its own right and changing quite a lot of file structures - so maybe good to get it in already. |
Member
|
@max-nextcloud Setting labels is highly appreciated ;) |
vinicius73
force-pushed
the
refactor/split-editor-wrapper
branch
from
July 19, 2022 14:41
41661ec to
0abdcbb
Compare
max-nextcloud
force-pushed
the
refactor/split-editor-wrapper
branch
2 times, most recently
from
July 26, 2022 07:12
a3cb6f0 to
4d17d6c
Compare
Collaborator
Author
|
/compile |
juliusknorr
approved these changes
Jul 26, 2022
max-nextcloud
force-pushed
the
refactor/split-editor-wrapper
branch
from
July 27, 2022 09:33
04b53b3 to
d1963d2
Compare
Collaborator
Author
|
/compile |
vinicius73
reviewed
Jul 27, 2022
| </script> | ||
|
|
||
| <style scoped lang="scss"> | ||
| .text-editor__main, .editor { |
Member
There was a problem hiding this comment.
We do not have a .editor element in this component.
vinicius73
approved these changes
Jul 27, 2022
Member
|
/rebase |
nextcloud-command
force-pushed
the
refactor/split-editor-wrapper
branch
from
July 27, 2022 21:44
9adc0e0 to
44ad290
Compare
`Editor/Status` handles the status display in the menubar. `Editor/DocumentStatus` handles the document messages on conflict etc. Also move all files that are only used within it into the `Components/Editor` dir. Signed-off-by: Max <max@nextcloud.com>
This will contain all editor related things. For now it only has the EditorMediaHandler Signed-off-by: Max <max@nextcloud.com>
This injects the `$editor` to display the content. One reason less to have the `$editor` in the `EditorWrapper`. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
refactor/split-editor-wrapper
branch
from
July 29, 2022 12:20
44ad290 to
4f58e4c
Compare
Collaborator
Author
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EditorWrapperis fairly large and hard to understand. It handles almost all editor related things - Sessions, Sync, Document, EditorLayout, Menubars etc.In order to rework the collaboration it might be helpful to split it into smaller pieces so it becomes easier to understand and handle.
Editor/Statushandles the status display in the menubar.