Investigate failing sync service test on stable27 #5154

Activity

1. max-nextcloud

   added

   bugSomething isn't workingSomething isn't working

   on Dec 21, 2023
2. max-nextcloud commented on Dec 21, 2023

   

   max-nextcloud

   on Dec 21, 2023

   CollaboratorAuthor

   More actions

   

   

   Server log is probably unrelated - maybe from a retry:

   {
     "reqId": "XNUpWmg1ATmxO2rATg7u",
     "level": 3,
     "time": "2023-12-21T05:51:19+00:00",
     "remoteAddr": "127.0.0.1",
     "user": "admin",
     "app": "ocs_api",
     "method": "POST",
     "url": "/ocs/v2.php/cloud/users?format=json",
     "message": "Failed addUser attempt: User already exists.",
     "userAgent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Cypress/13.6.1 Chrome/114.0.5735.289 Electron/25.8.4 Safari/537.36",
     "version": "27.1.5.1",
     "data": {
       "app": "ocs_api"
     }
   }
3. max-nextcloud

   added

   testsIf you write them we ♥ youIf you write them we ♥ you

   bug: regression

   on Dec 21, 2023
4. max-nextcloud

   changed the title [-]Investigate failing sync service test[/-] [+]Investigate failing sync service test on stable27[/+] on Dec 21, 2023
5. max-nextcloud commented on Dec 22, 2023

   

   max-nextcloud

   on Dec 22, 2023

   CollaboratorAuthor

   More actions

   running the last passing commit of text with the latest commit of server stable27 passes: https://github.com/nextcloud/text/actions/runs/7104754058/job/19905039693
   At the same time the current state of text with the last passing commit of server still fails: https://github.com/nextcloud/text/actions/runs/7303886691/job/19905235351

   So looks like this somehow broke on the text side of things rather than the server side.
6. max-nextcloud

   added

   technical debt

   on Dec 28, 2023
7. max-nextcloud

   added this to 📝 Productivity teamon Jan 2, 2024
8. github-project-automation

   moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity teamon Jan 2, 2024
9. mejo-

   moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Productivity teamon Mar 10, 2024
10. mejo- commented on Apr 3, 2024

    

    mejo-

    on Apr 3, 2024

    Member

    More actions

    I tried to understand what happens here, but failed so far.

    Two tests in sync.spec.js fail reliably when running them with cypress run locally - even though they pass reliably with cypress open:

    • saves the actual file and document state
    • saves on close

    Both tests load a document, edit the document, download the file and see whether the edits are in the downloaded file. The first one does a manual save before download, the second closes the document before download.

    In the screenshots it's obvious that the file got saved. I suspected a race condition, but adding cy.wait() at different places in the test doesn't change the situation. The downloaded file always stays the one initially uploaded, without the editing changes.
11. mejo- commented on Apr 3, 2024

    

    mejo-

    on Apr 3, 2024

    Member

    More actions

    Ok, found a reliable fix now: #5601
12. mejo-

    linked a pull request that will close this issue[stable27] test(cypress): Wait for syncs after opening+editing in in `sync.spec.js` #5604on Apr 3, 2024
13. mejo- commented on Apr 3, 2024

    

    mejo-

    on Apr 3, 2024

    Member

    More actions

    Fixed by #5604
14. mejo-

    closed this as completedon Apr 3, 2024
15. github-project-automation

    moved this from 📄 To do (~10 entries) to ☑️ Done in 📝 Productivity teamon Apr 3, 2024